Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set (default) rowheight #110

Closed
thomrob opened this issue Mar 7, 2019 · 5 comments
Closed

set (default) rowheight #110

thomrob opened this issue Mar 7, 2019 · 5 comments
Assignees

Comments

@thomrob
Copy link

thomrob commented Mar 7, 2019

Looking for a way to change the rowheight, and i'm not sure if/how this is possible at the moment.
I tried to do it myself using using https://www.ag-grid.com/javascript-grid-row-height, but was not lucky.

Maybe it's possible to create a setRowHeight method on the ag-grid, similar to BBjGrid?
This way we would be able to do the most common scenario ; set the default rowheight once when initializing the grid.

@hyyan hyyan self-assigned this Mar 8, 2019
@hyyan hyyan added BBj labels Mar 8, 2019
@hyyan
Copy link
Member

hyyan commented Mar 8, 2019

@thomrob row height feature is not available for BBj yet, but the feature makes sense and we will implement it soon.

hyyan added a commit that referenced this issue Mar 11, 2019
hyyan added a commit that referenced this issue Mar 19, 2019
feat: Add the ability to set the row height globally and by row

See #110

Fixes #110
@hyyan
Copy link
Member

hyyan commented Mar 19, 2019

@thomrob this is implemented in dev now, please see Demo.bbj to learn the usage

Methods

  1. setRowHeight(height!) : Set the row height globally
  2. setRowHeight(row! , height!) : set the height for a specific row (works only after setData)

@hyyan hyyan closed this as completed Mar 19, 2019
@thomrob
Copy link
Author

thomrob commented Mar 20, 2019

thank you! The first method is working, but the second one looks like it's not working here. (although not a problem for me as i don't need to set individual rowheights).
I''m trying to pick development again next months, happy to use the ag-grid as a replacement for some slow/large bui-grids.

@hyyan
Copy link
Member

hyyan commented Mar 20, 2019

@thomrob Demo.bbj uses the setRowHeight(row! , height!) to change the first-row height when you select the balham-dark theme. Please check that and feel free to open another issue if this still does not work for.

@thomrob
Copy link
Author

thomrob commented Mar 20, 2019

thanks, i does work in the demo.bbj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants