Feature#01 initial setup #3

SpidySamurai · 2021-05-07T19:00:41Z

Description

What?: Init rails project. Setup database engine with postgres and install gems and dependencies for the project.
Why?: In order to develop with the same environment configurations. For more background, see ticket Feature Feature#0 git templates #1

Non-functional requirements

Configures rubocop , rubycritic, sandi_meter as code review tools for quality

Setup tests

Configures rspec-rails for testing.

Setup frontend

Configures bootstrap 5 as frontend framework.

Preconditions

 bundle install & yarn install 
 rails server and bin/webpack-dev-server

Database creation

rails  db:create
rails db:migrate

Execute metrics code and sandi_meter

rake metrics_code

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

…ments Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

Co-authored-by: marianoalarcon <mariano.alarcon@hotmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com>

Arkamis

LGTM 👍

anxhe

You are ready to begin

anxhe · 2021-05-10T17:33:58Z

Gemfile

+  # Call 'byebug' anywhere in the code to stop execution and get a debugger console
+  gem 'byebug', platforms: %i[mri mingw x64_mingw]
+  gem "rspec-rails", "~> 5.0"
+  gem "sqlite3", "~> 1.4"


Perhaps can you remove this gem , I noticed you are not using it in config/database.yml

That's right, thanks! in principle we thought to use sqlite3 for development and testing, in this way we keep postgres only for production, but then we choose to keep everything in postgres

anxhe · 2021-05-10T17:43:45Z

Gemfile

+  gem 'rake', '~> 13.0'
+  gem 'rubocop-rails', '~> 2.10'
+  gem 'rubycritic', '~> 4.6'
+  gem 'rubycritic-small-badge', '~> 0.2.1'


Could it be that you forgot to configure this gem? or are you going to do it later in other issue?

…list

Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

…pec_helper Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

anxhe · 2021-05-12T20:59:58Z

Gemfile

@@ -52,9 +52,13 @@ group :development do
  gem 'rubocop-rails', '~> 2.10'
  gem 'rubycritic', '~> 4.6'
  gem 'rubycritic-small-badge', '~> 0.2.1'
+  gem "hamlit", "~> 2.15"


Yes ! This gem improves the dev !

anxhe

Nice, I see you included several things, it seems that my previous review was gone

anxhe · 2021-05-12T21:12:36Z

lib/tasks/metrics_code.rake

-        --format console
-      )
-      task.paths = FileList["#{dir}/**/*.rb"]
+      RubyCritic::RakeTask.new("_rubycritic:#{dir}") do |task|


Nice , I am glad that you liked this approach 😉

Yes, we liked the order you keep when making the project settings. We find it efficient and effective

anxhe · 2021-05-12T21:20:12Z

spec/spec_helper.rb

+  ])
+end
+SimpleCov.minimum_coverage(65)
+SimpleCovSmallBadge::Formatter.class_eval do


This monkey patch is very useful without this gem fails , can see context here: MarcGrimme/simplecov-small-badge#15

Ohh, thank u very much, knowing these kind of stuff helps a lot!

marianoalarcon and others added 14 commits May 7, 2021 12:43

chore: Add template issues

8d81990

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add template pull request

dd65c9f

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Init rails app

e3e8887

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add rubocop

073ab44

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add rubocop-rails

700b15b

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add rubycritic

8cc1cb3

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add rubycritic-small-badge

9daf7b4

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add rake gem and run Rubocop to Gemfile

39c7a96

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add rpec-rails Gemfile

f174a5f

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Install rpec-rails

1832abd

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add bootstrap

2cc1d52

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Add sqlite3, for test and development environments

58e25eb

Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: setup database.yml and slite3 for test and development environ…

182d889

…ments Co-authored-by: SpidySamurai <javierchiortiz@gmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com> Co-authored-by: JorgeDDW <hi@jorgedev.com>

chore: Postgresql config database.yml

a2daaf4

Co-authored-by: marianoalarcon <mariano.alarcon@hotmail.com> Co-authored-by: facundotoconas <facutoconas88@gmail.com>

SpidySamurai added the review required review required label May 7, 2021

SpidySamurai requested review from anxhe, Arkamis, EusebioAjas, facundotoconas, JorgeDDW and marianoalarcon May 7, 2021 19:14

Arkamis previously approved these changes May 10, 2021

View reviewed changes

anxhe previously approved these changes May 10, 2021

View reviewed changes

marianoalarcon modified the milestone: Sprint 1 May 11, 2021

marianoalarcon added this to In progress in Denuncia ciudadana via automation May 11, 2021

marianoalarcon linked an issue May 11, 2021 that may be closed by this pull request

Feature#01_Initial-setup #2

Closed

4 tasks

marianoalarcon moved this from In progress to Review in progress in Denuncia ciudadana May 11, 2021

chore(.ruby-version): update ruby-version in order to add the gemset …

9b4acd3

…list

marianoalarcon and others added 3 commits May 11, 2021 12:31

chore: Add hamlit and hamlit-rails gems

ea0eacc

Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

chore: Add simple_form gem

3cdaaa4

Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

chore: Add annotate gem

91bbfa0

Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

SpidySamurai moved this from Review in progress to In progress in Denuncia ciudadana May 11, 2021

chore: Install simple_form

46b417d

Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

marianoalarcon dismissed stale reviews from anxhe and Arkamis via 46b417d May 11, 2021 16:39

Denuncia ciudadana automation moved this from In progress to Review in progress May 11, 2021

SpidySamurai requested review from anxhe and Arkamis May 11, 2021 18:07

marianoalarcon and others added 2 commits May 12, 2021 11:29

chore: Add sandi_meter gem and add rake tasks for metrics code

ffaac49

Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

Add simplecov and simplecov-small-badge for coverage and add config s…

1390f0c

…pec_helper Co-authored-by: SpidySamurai <SpidySamurai@users.noreply.github.com> Co-authored-by: facundotoconas <facundotoconas@users.noreply.github.com>

facundotoconas approved these changes May 12, 2021

View reviewed changes

marianoalarcon approved these changes May 12, 2021

View reviewed changes

anxhe approved these changes May 12, 2021

View reviewed changes

SpidySamurai merged commit 81ce202 into master May 13, 2021

Denuncia ciudadana automation moved this from Review in progress to Done May 13, 2021

marianoalarcon removed the review required review required label May 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature#01 initial setup #3

Feature#01 initial setup #3

SpidySamurai commented May 7, 2021 •

edited by marianoalarcon

Loading

Arkamis left a comment

anxhe left a comment

anxhe May 10, 2021

marianoalarcon May 12, 2021

anxhe May 10, 2021

anxhe May 12, 2021

SpidySamurai May 13, 2021

anxhe left a comment

anxhe May 12, 2021

marianoalarcon May 13, 2021

anxhe May 12, 2021

SpidySamurai May 13, 2021

Feature#01 initial setup #3

Feature#01 initial setup #3

Conversation

SpidySamurai commented May 7, 2021 • edited by marianoalarcon Loading

Description

Non-functional requirements

Setup tests

Setup frontend

Preconditions

Execute metrics code and sandi_meter

Arkamis left a comment

Choose a reason for hiding this comment

anxhe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anxhe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpidySamurai commented May 7, 2021 •

edited by marianoalarcon

Loading