Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str/byte, new server message check, agents listing bug #103

Merged
merged 14 commits into from Feb 29, 2020

Conversation

@hypnoticpattern
Copy link

hypnoticpattern commented Feb 13, 2020

agent.py: Stripped trailing white spaces. In some cases the default HTML page and the current one, used to check if a new server message arrived, have a different number of trailing white spaces that makes the agent to try to base64 decode the HTML causing an exception within the agen:

main() exception: 'utf-8' codec can't decode byte 0x99 in position 0: invalid start byte
main() exception: 'utf-8' codec can't decode byte 0x99 in position 0: invalid start byte
main() exception: 'utf-8' codec can't decode byte 0x99 in position 0: invalid start byte

empire.py: str/byte error trying to read the file.

helpers.py: Typo

messages.py: In some cases when an agent doesn't fully complete a connection the hostname is Null. In Python 3 that causes an unsupported format string passed to NoneType.__format__ exception when the command agents is invoked. If that happens the agents listing breaks until the offending agent is removed. Reference

hypnoticpattern and others added 12 commits Jan 31, 2020
Merging with Empire 3.0.6
Merging Dev
@Cx01N Cx01N added the bug label Feb 15, 2020
@Cx01N
Cx01N approved these changes Feb 29, 2020
@Cx01N Cx01N merged commit c7c373a into BC-SECURITY:dev Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.