Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query database from plugin #48

Closed
cppcooper opened this issue Oct 18, 2021 · 4 comments · Fixed by #61
Closed

Query database from plugin #48

cppcooper opened this issue Oct 18, 2021 · 4 comments · Fixed by #61
Labels
enhancement New feature or request Task

Comments

@cppcooper
Copy link
Contributor

cppcooper commented Oct 18, 2021

So our plugin needs to query the database, for at least one reason as of now. We're going to need to update md5 checksums of files which we'll be modifying. We initially went about this with libpqxx which we have two issues about:
#37 - deals previous issues linking libpqxx
#47 - deals with the plugins dependency on libpqxx and the lack thereof in the docker environment

Lately, we've talked about trying to remove the libpqxx dependency and thereby simplify deployment of this plugin. In order to remove the dependency we need something to replace it, @brianzhouzc thinks we may be able to find undocumented features of the Orthanc SDK which will allow us to perform queries on the database. [edit: This means we'll need to research a bit, which involves issue #35]

One way or another we need something that makes sense, the simpler the better.. and if the SDK can't provide what we need we will still need to figure out precisely how we want to integrate the library into the plugin.

@cppcooper cppcooper added enhancement New feature or request Task labels Oct 18, 2021
@cppcooper
Copy link
Contributor Author

cppcooper commented Oct 19, 2021

We can potentially evade any need for direct database queries as per my comments in #35

@cppcooper
Copy link
Contributor Author

We can potentially evade any need for direct database queries as per my comments in #35

No longer the case, we've decided a separate table for PHI is ideal and so we must implement new rest api callbacks which will serve to interface the custom db table.

@cppcooper cppcooper linked a pull request Nov 1, 2021 that will close this issue
@brianzhouzc
Copy link
Contributor

Iwan is experimenting with libpqxx within the plugin now.

@brianzhouzc
Copy link
Contributor

Working in feat-phi branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants