REF: fall back to QLabel if no channel is associated with PyDMLabel #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this. |
prjemian
approved these changes
May 27, 2020
|
It's not bad to read through at all! 👍 |
|
Do you want anything else from my PRs in this repo @prjemian? |
This was referenced Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't have to be accepted here, but it's one possible solution for a downstream typhos issue that may be agreeable.
In downstream Typhos, we have specific stylesheets for PyDMLabel, making the auto-converted AreaDetector screens look particularly bad:
With this fix, the channel-less PyDMLabel is recast to a
QLabel:Separately - would you mind a PR that fixes trailing whitespace issues in the repository? My editor found and fixed hundreds automatically, making contributing a bit more difficult.