Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutter devices need a base class #86

Closed
prjemian opened this issue Feb 13, 2019 · 1 comment
Closed

shutter devices need a base class #86

prjemian opened this issue Feb 13, 2019 · 1 comment
Assignees
@prjemian
Labels
enhancement
Milestone
milestone-2019-03

Comments

@prjemian
Copy link
Contributor

prjemian commented Feb 13, 2019 •
edited
Loading

Goal is to remove duplicated code and simplify additions of features such as post-move sleep.
@prjemian prjemian added this to the release in May 2019 milestone Feb 13, 2019
@prjemian prjemian self-assigned this Feb 13, 2019
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 first pass at base class established
97ab5b8
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 allow delay with either open()/close() or set()
4c36100
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 docs
f5f8539
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 re-group for subclass suggestion
307d845
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 DOC
94578a6
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86
eae52c6
@prjemian
Copy link
Contributor Author

Shutters may have one or two control signals plus an optional status signal to track. The current ShutterBase is an example of a one-signal shutter.

prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 refactor new base class
b1c0af8
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 code simpler and more consistent
03e367e
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 EpicsMotorShutter
a27fa02
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 allow for optional delay after motor moves
a3e6360
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 sort methods again
b7ed396
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 DOC
72c6153
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 SimulatedApsPssShutterWithStatus
3494f1a
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 compatible call with real APS PSS shutter support
77700d7
prjemian added a commit that referenced this issue Feb 13, 2019
@prjemian
#86 WIP - newApsPssShutterWithStatus
5ed80d0
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 ApsPssShutterWithStatus
0fa3037
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 get text values from the PV
6e7a0d4
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 developer tools
b1ccac3
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 APS PSS shutter PVs (at 9-ID) use "Open" & "Close"
0496e8f
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 WIP -- APS PSS shutters
693e05f
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 ApsPssShutter
d8c5cb8
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 ApsPssShutterWithStatus(ApsPssShutter)
1fd45c5
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 DOC
686768a
prjemian added a commit that referenced this issue Feb 14, 2019
@prjemian
#86 shuffle
76a42bf
@prjemian prjemian mentioned this issue Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
enhancement
Projects
None yet
Milestone
milestone-2019-03
Development

No branches or pull requests
1 participant
@prjemian