Support for DG-645 digital delay/pulse generator #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
canismarko
commented
Aug 25, 2023
•
canismarko
commented
- Fixes Ophyd device for DG-645 #874
prjemian
reviewed
Aug 30, 2023
| @@ -201,6 +201,7 @@ Other Support | |||
| ~apstools.devices.flyer_motor_scaler.SignalValueStack | |||
| ~apstools.devices.srs570_preamplifier.SRS570_PreAmplifier | |||
| ~apstools.devices.struck3820.Struck3820 | |||
| ~apstools.devices.delay.DG645Delay | |||
There was a problem hiding this comment.
Also add (further down in this file) lines for this module similar to: https://github.com/BCDA-APS/apstools/blob/dd3d9949154e54911dbc361942bbf9846161f5b3/docs/source/api/_devices.rst?plain=1#L266C1-L270
There was a problem hiding this comment.
.. automodule:: apstools.devices.dict_device_support
:members:
:private-members:
:show-inheritance:
:inherited-members:
prjemian
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
LGTM! Thanks, @canismarko! See if you can merge, once the CI finishes.
|
I'll make a note in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.