Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch linting to use ruff #930

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Switch linting to use ruff #930

merged 6 commits into from
Feb 28, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the task Something to be done. label Feb 26, 2024
@prjemian prjemian added this to the 1.6.19 milestone Feb 26, 2024
@prjemian prjemian self-assigned this Feb 26, 2024
@prjemian
Copy link
Contributor Author

Nice. 'ruff check' analysis found unused imports and one block of duplicated code (two definitions of the same function).

MDecarabas
MDecarabas approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Feb 27, 2024
Closed
Closed
@prjemian prjemian merged commit 6841c83 into main Feb 28, 2024
2 checks passed
@prjemian prjemian deleted the 909-ruff-linting branch February 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas approved these changes

@mdwyman mdwyman Awaiting requested review from mdwyman

@rodolakis rodolakis Awaiting requested review from rodolakis

Assignees

@prjemian prjemian

Labels
task Something to be done.
Projects
None yet
Milestone
1.6.19
Development

Successfully merging this pull request may close these issues.

Switch linting to use ruff
2 participants
@prjemian @MDecarabas