New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh_grid feature for 8-ID #958

Merged

MDecarabas merged 10 commits into main from xpcs_mesh

Apr 12, 2024

Collaborator

MDecarabas commented Apr 8, 2024

No description provided.

Codrea added 2 commits

April 8, 2024 13:12


          plan done, TODO: documentation + cleanup

4962aab


          documented the mesh_grid_scan plan

b086861

MDecarabas added the enhancement label

MDecarabas added this to the 1.6.19 milestone

MDecarabas requested a review from prjemian

April 8, 2024 19:46

MDecarabas self-assigned this

MDecarabas requested a review from rodolakis

April 8, 2024 19:46

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

prjemian reviewed

View reviewed changes

Contributor

prjemian left a comment

Couple things to examine. On second thought, the logger.warning() for missing hints might be unwelcome.

Codrea added 3 commits

April 11, 2024 14:07


          Added documentation

5609d38


          Added cytools to pyproject.toml

70f2084


          Replaced while loop

9dceaa2

MDecarabas requested a review from prjemian

April 11, 2024 19:41

prjemian reviewed

View reviewed changes

apstools/plans/xpcs_mesh.py Outdated Show resolved Hide resolved

Contributor

prjemian commented Apr 12, 2024

Can you finish this today?

Codrea added 3 commits

April 12, 2024 11:42


          Merged nd_step & 1d_step verify funtions

b9f7faf


          got rid of try/except in import, no more enumerate

b93d7ef


          fixed print statement syntax

ccecf2f

MDecarabas requested a review from prjemian

April 12, 2024 16:55

Contributor

prjemian commented Apr 12, 2024

One more addition:

apstools/environment.yml

Line 36 in ccecf2f

- sphinx >=5

After this line, add:

 - toolz

Codrea added 2 commits

April 12, 2024 13:57


          Added toolz to environment.yaml

c4d570c


          formatting

9ab1746

prjemian approved these changes

View reviewed changes

Contributor

prjemian left a comment

Great! Assume the pin on toolz is needed. Could synchronize same pinning in both pyproject.toml and environment.yml. Not a blocker, though.

MDecarabas merged commit 5301e19 into main

13 checks passed

MDecarabas deleted the xpcs_mesh branch

April 12, 2024 21:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment