Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluesky-queueserver v0.0.18 changes changes group admin to primary #134

Closed
prjemian opened this issue Apr 29, 2023 · 7 comments · Fixed by #135
Closed

bluesky-queueserver v0.0.18 changes changes group admin to primary #134

prjemian opened this issue Apr 29, 2023 · 7 comments · Fixed by #135
Assignees
Labels
task routine work
Milestone

Comments

@prjemian
Copy link
Contributor

prjemian commented Apr 29, 2023

A change was made to main in commit 20a9e3f but there are other files to be changed as well. Deserves its own branch and PR.

@prjemian prjemian added the task routine work label Apr 29, 2023
@prjemian prjemian self-assigned this Apr 29, 2023
prjemian added a commit that referenced this issue Apr 29, 2023
prjemian added a commit that referenced this issue Apr 29, 2023
@prjemian prjemian changed the title bluesky-queueserver v0.0.18 changes needs group admin to primary bluesky-queueserver v0.0.18 changes changes group admin to primary Apr 29, 2023
@prjemian
Copy link
Contributor Author

After changes to main were reversed, CI for Py 3.8 failed (tests all passed) with:

coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs

which seems to be a new problem.

@prjemian
Copy link
Contributor Author

Perhaps this suggestion:

run: coveralls --service=github

coveralls debug
coveralls --service=github --finish

The change exists on line 160. Guessing it needs to be added on line 159. Start the branch with that change first.

@prjemian
Copy link
Contributor Author

prjemian commented Apr 29, 2023

per the help:

Usage:
    coveralls [options]
    coveralls debug [options]

    Debug mode doesn't send anything, just outputs json to stdout. It also
    forces verbose output. Please use debug mode when submitting bug reports.

Global options:
    --service=<name>  Provide an alternative service name to submit.
    --rcfile=<file>   Specify configuration file. [default: .coveragerc]
    --output=<file>   Write report to file. Doesn't send anything.
    --merge=<file>    Merge report from file when submitting.
    -h --help         Display this help.
    -v --verbose      Print extra info, always enabled when debugging.

prjemian added a commit that referenced this issue Apr 29, 2023
@prjemian
Copy link
Contributor Author

Reading further, remove line 159 altogether.

@prjemian
Copy link
Contributor Author

Define COVERALLS_REPO_TOKEN per lemurheavy/coveralls-public#1435 (comment)

prjemian added a commit that referenced this issue Apr 29, 2023
@prjemian
Copy link
Contributor Author

Different advice from lemurheavy (above):

  • Sign into Coveralls via GitHub
  • Go to Add Repos
  • Un-tick then re-tick the failing project
  • Re-run the failing CI jobs

@prjemian prjemian added this to the v1.0.0 milestone Apr 29, 2023
@prjemian
Copy link
Contributor Author

CI passes now. Proceed with #134 now

prjemian added a commit that referenced this issue Apr 29, 2023
prjemian added a commit that referenced this issue Apr 29, 2023
prjemian added a commit that referenced this issue Apr 29, 2023
prjemian added a commit that referenced this issue Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task routine work
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant