initial implementation of UnivariateProbabilitySimulator #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their signatures and behaviours will differ across subclasses
- unit tests still to be written - docstrings to be reviewed/updated
j-ittner
changed the title
jason-bentley
suggested changes
Aug 26, 2020
There was a problem hiding this comment.
Code looks okay. I gave it a test run on my simulated classification data, and the result is below. Seems to work as expected. Shape for something linear on the log-odds scale looks about right, and the line appears to centre around the positive class probability of 0.564.
Before merging a couple of things:
- Change the label for the y-axis on the plot, no longer uplift but rather just the positive class probability or predicted probability of target.
- Ensure doc strings are sufficient.
# Conflicts: # src/facet/simulation/_simulation.py
j-ittner
requested review from
konst-int-i and
jason-bentley
and removed request for
jason-bentley
konst-int-i
approved these changes
Aug 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13.