CAS: Crosslisted Functionality Broken #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #419
Description:
There was no crosslisted parameter being passed to the template for the admin courseManagement page. This was resulting in an error since the variable did not exist. Intitialy, @bryantal added an empty list as the parameter so that the page does not break. After analyzing critically the frontend page (app/templates/snips/courseElements/adminCourseTable.html) we thought that a dictionary datatype was the best structure to pass our data hence crosslisted is not a list in this PR. It is a dictionary.
Test.
Navigate to courseManagement/crossListed. Change terms and confirm if the crosslisted column in the table is correct.