Page template + Sidebar #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alex-418
commented
Sep 28, 2017
alex-418
commented
|
@bdolor yarn.lock 430 deletions 🤔 no bueno ? |
bdolor
suggested changes
Sep 29, 2017
| </aside> | ||
| @endif | ||
| </div> | ||
| <div class="wrap container container-fluid " role="document"> |
There was a problem hiding this comment.
container + container-fluid is redundant. one or the other. (container-fluid)
| @endif | ||
| </div> | ||
| <div class="wrap container container-fluid " role="document"> | ||
| <div class="content clearfix row-fluid"> |
There was a problem hiding this comment.
.row-fluid exists in bs3 only. bs4 it is row. what purpose does .clearfix serve?
| </div> | ||
| <div class="wrap container container-fluid " role="document"> | ||
| <div class="content clearfix row-fluid"> | ||
| <main class="col-sm-8 clearfix"> |
There was a problem hiding this comment.
.clearfix necessary? .main is declared in bs4 - why was it was taken out?
bdolor
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.