-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Av and Age priors, allow verify_params failures #124
Conversation
In the verify_params changes, I'm not sure having the exit being overridden for all possible exits is a good idea. In fact, ideally the override would not be done at all, but the verify_params logic changed to handle the two cases mentioned - no fA and/or fixed Rv extinction curves. @lcjohnso: Is such a change in the logic not possible/straightforward? |
Re: @karllark's suggestion, I added logic to verify_params that allows for non-
I'm leaving the |
Also: I added initial documentation of datamodel.py/run_beast.py, including HowTo instructions for implementing new optional features. This addition is a good step towards closing Issue #71 -- please comment there on additions that might still be needed before closing issue. |
x: vector | ||
x values | ||
a: float | ||
Single parameter in exp: a*e^-ax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be N*e^-ax.
It would be nice if the 'a' parameter had a variable name that was more descriptive. I can't think of one offhand, but it is not some kind of timescale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I corrected the notation, but am leaving the param as "a" -- could use "decay_rate" or "decay_param" but that seems overkill. Instead, I added additional text in docstring.
x values | ||
a: float | ||
Single parameter in exp: a*e^-ax | ||
N: floats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this parameter needed? Shouldn't this be set by the desire to have this prior integrate to 1 over the min/max age range? If so, then it is not needed and should be set inside the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the format of the other prior choices. Will leave as is.
beast/tools/verify_params.py
Outdated
|
||
def verify_one_input_format(param, param_name, param_format, param_lim): | ||
if param_max-param_min == 0.: | ||
print('Warning: '+param_name+' grid is single-valued.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit picky point. I don't think this is a warning. There is no problem with single value parameters in a grid. I worry that having it issue a warning makes it sound like this is bad. Maybe something less "scary" like "Info"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "Note:"
@@ -0,0 +1,73 @@ | |||
Running the BEAST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this doc file! Many thanks for starting it. I know there is material I will add once I think about it more.
Adjust Av and Age priors, allow verify_params failures Failures are understood and have to do with the development version of astropy
Here I enable three optional features:
While not included in this PR, I would be happy to add info about what needs to be changed in run_beast.py and datamodel.py to use these updates, but I'll wait until the datamodel.py documentation page is drafted (Issue #71).