Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update convex hull code #789

Closed

Conversation

christinawlindberg
Copy link
Contributor

  1. Updated convex hull path with concave hull method to make it possible to fit fields with concave footprints. Regular convex footprints are still fittable with this method.
  2. Create a diagnostic plot to visualize the area where ASTs can be placed.
    E.g.
    image

@christinawlindberg
Copy link
Contributor Author

Would fix #779

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Attention: Patch coverage is 17.94872% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 42.16%. Comparing base (bcc8cb5) to head (fe8373a).

Current head fe8373a differs from pull request most recent head a3eb4c3

Please upload reports for the commit a3eb4c3 to get more accurate results.

Files Patch % Lines
beast/tools/cut_catalogs.py 17.94% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   42.00%   42.16%   +0.15%     
==========================================
  Files         108      107       -1     
  Lines       10275    10135     -140     
==========================================
- Hits         4316     4273      -43     
+ Misses       5959     5862      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galaxyumi
Copy link
Contributor

I tried this on LUVIT galaxies, which have more complicated footprints from multiple cameras as well as more significant density variation within one HST pointing. Unfortunately this doesn't fix the problem reported in #779. Also, the shapely package version seems to affect its usage. The version @christinawlindberg used was 2.0.1 for her development.

@karllark
Copy link
Member

@christinawlindberg can you response to @galaxyumi's comment above?

@christinawlindberg christinawlindberg closed this by deleting the head repository May 23, 2024
@karllark
Copy link
Member

Closing. New PR will be opened base don a branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants