Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Physics Shield and Closed Solid Field #776

Closed

Conversation

TheDarkBomber
Copy link
Contributor

@TheDarkBomber TheDarkBomber commented Sep 5, 2016

Reverts #772

Even though the fizzlers are not perfect, they CAN be updated in the FUTURE. Realise that before you revert a pull request.

(Physics Shield name debated)

@TeamSpen210 TeamSpen210 changed the base branch from master to dev September 5, 2016 19:53
@TheDarkBomber
Copy link
Contributor Author

Is this going to be merged into the Dev branch?

@TeamSpen210
Copy link
Member

TeamSpen210 commented Sep 7, 2016

There's a couple things first:

  • The physics shield shouldn't have a player clip, it's only for physics objects. Additionally change the author, and the name should be 'Physler'.
  • Add a 50s and P1 variant at least - those have different fizzler models, and would look wrong if Clean.

@TeamSpen210 TeamSpen210 changed the title Revert "Revert "Extra Fizzlers"" Add Physler and Closed Solid Field Sep 7, 2016
@TheDarkBomber
Copy link
Contributor Author

Felix Griffin didn't even call it a Physler.

@TheDarkBomber TheDarkBomber changed the title Add Physler and Closed Solid Field Add Physics Shield and Closed Solid Field. Sep 7, 2016
@TheDarkBomber TheDarkBomber changed the title Add Physics Shield and Closed Solid Field. Add Physics Shield and Closed Solid Field Sep 7, 2016
@TheDarkBomber
Copy link
Contributor Author

TheDarkBomber commented Sep 9, 2016

To-do List:

  • Change author to Felix Griffin and add "Other Names" in Physics Shield
  • Add 50s variants
    • Physics Shield 50s variant
    • Closed Solid Field 50s variant

"Nodraw" "BEE2/fizz/fourthreaper/player_clip_electric"
"Keys"
{
"classname" "func_clip_vphysics"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clips, make it just use tools/toolstrigger, and remove solidity/solidbsp/spawnflags - those aren't used for func_clip_vphysics. player_clip_electric is only useful for player clips.

@TheDarkBomber
Copy link
Contributor Author

It still works.

@TeamSpen210
Copy link
Member

It does, but removing those means you don't need to pack that material.

@TeamSpen210 TeamSpen210 added the New Feature A new item, option, or other feature label Sep 10, 2016
@TheDarkBomber
Copy link
Contributor Author

50s variant of Closed Solid Field added. Will this be merged into dev?

@TeamSpen210
Copy link
Member

I'll want to do a quick lookover first, but yes.

@TheDarkBomber
Copy link
Contributor Author

TheDarkBomber commented Sep 11, 2016

Ok

My Contribution Page

@TheDarkBomber
Copy link
Contributor Author

Is it going to be merged?

@TheDarkBomber
Copy link
Contributor Author

The Physics Shield should block portals as an enhancement, and to make it look more like a fizzler.
Also, do not rename it directly to Physler, keep it as an "Other Name".

@TeamSpen210
Copy link
Member

No, the item is explicitly supposed to not block portal shots. Play this map.

@TheDarkBomber
Copy link
Contributor Author

TheDarkBomber commented Sep 16, 2016

People might not like the fact that you can shoot through it. And I have played that map. It will improve maps if you can't shoot through it.

@TeamSpen210
Copy link
Member

No, it will make that map impossible to make. If it blocks portal shots, it's not a Physler anymore.

@TheDarkBomber TheDarkBomber changed the title Add Physics Repulsion Field and Closed Solid Field Add Physics Shield and Closed Solid Field Jan 5, 2017
@TheDarkBomber
Copy link
Contributor Author

I'll still need to be collaborator in order to update these items.

@LautaroL20
Copy link
Member

Not really, you can create a separated new branch using your github app containing your addon, thats what i did with my Cold Light Strip addon. I didn´t use this pull request system at all.....

@TheDarkBomber
Copy link
Contributor Author

@LautaroL20 You need to be collaborator to do that.

@LautaroL20
Copy link
Member

Did u even tried to send a small commit trhough ghitub to see if it works for you?

@TheDarkBomber
Copy link
Contributor Author

It doesn't work.

@LautaroL20
Copy link
Member

:(

@TheDarkBomber
Copy link
Contributor Author

@LautaroL20 Can you atleast merge tdb_fizz with dev so it is in the Development Version? And add P1 & Overgrown variants?

@LautaroL20
Copy link
Member

Well, first ill need to ask Spencer who is the own of this Beemod version, if hes agree be sure ill merge it into dev.

@LautaroL20
Copy link
Member

@TheDarkBomber - This is the fist time i tested your addon, and i saw there are a couple of things ill want to report to your repository section.

@TheDarkBomber
Copy link
Contributor Author

Ok. Report them.

@TeamSpen210
Copy link
Member

Don't merge things to dev unless they're actually ready for release - this isn't.

@TheDarkBomber
Copy link
Contributor Author

@TeamSpen210 Re-add me as collaborator so I can update these items.

@vrad-exe
Copy link
Member

@TheDarkBomber - You don't need to be a collaborator, just update them on your contribution repository and @TeamSpen210 will merge them when finished.

@vrad-exe
Copy link
Member

@TheDarkBomber - You should finish these so they can be merged.

TheDarkBomber added a commit to TheDarkBomber/BEE2-items-TheDarkBomber-Contributions that referenced this pull request Jan 28, 2017
This makes the Closed Solid Field ready for release. (BEEmod#776)
@TheDarkBomber
Copy link
Contributor Author

TheDarkBomber commented Jan 28, 2017

Ok, I have finished the Closed Solid Field with the P1 variant, so it is ready for release, but I need to now add the Overgrown PRF. Also, it says there are conflicts, but this PR uses different branches. After I create the Overgrown PRF, this PR can be closed, and my fizz branch can be merged via commit to the tdb_csfi branch, which will then be merged to the dev branch via commit.

TheDarkBomber added a commit to TheDarkBomber/BEE2-items-TheDarkBomber-Contributions that referenced this pull request Jan 28, 2017
The Physics Repulsion Field has now been completed and is ready for release. (BEEmod#776)
@TheDarkBomber
Copy link
Contributor Author

Overgrown PRF added! These items are now ready for release! :)

@TheDarkBomber
Copy link
Contributor Author

Will be implemented for next release. :)

Pull Request Closed!

@vrad-exe
Copy link
Member

Finally! Now it's time to get to work on the Blue Portals Pack!

@TheDarkBomber
Copy link
Contributor Author

@Luke18033 The PR for the BP pack will not be opened right away, though. It will be opened when it is ready.

@TeamSpen210
Copy link
Member

Open it once you have something, so we can comment on it whenever.

@TheDarkBomber
Copy link
Contributor Author

Ok. I have the music made by @Byzarru.

@vrad-exe
Copy link
Member

Should the branch for this be deleted now that the items are in dev?

@vrad-exe vrad-exe deleted the revert-772-revert-765-fizz branch October 14, 2017 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution User-contributed feature New Feature A new item, option, or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants