ES-2153 - Added support for multiple files and for updating default parameters #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrei-Predoiu
added
enhancement
|
@Gaardsholt do you think there will be timeout issues because of how long it can take to run this now? |
Gaardsholt
reviewed
Apr 18, 2024
Andrei-Predoiu
changed the title
…- BREAKING change Added defaults for directory and schedule
dennisc87
reviewed
Apr 18, 2024
dennisc87
reviewed
Apr 18, 2024
Gaardsholt
approved these changes
Apr 19, 2024
Co-authored-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Gaardsholt
approved these changes
Apr 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multiple files.
directoryis set to a folder, dependabot-circleci will travel the whole directory tree and check all yml/yaml files.directoryis now.circleci/config.yml. This different than the old behavior and will break stuff in our templates.Added support for updating the default value of parameters
Example:
https://github.com/BESTSELLER/cci-common-test/pulls
Files that can't be updated:
https://github.com/BESTSELLER/cci-common-test/blob/49ca40c5737faf0750552dfeeb7b53c58ae8e51d/src/jobs/build_n_push_docker.yml#L11
This will fix: #194