Fixed checking for error message in Vault support even if the transac…

…tion was successful (#1836)

Hooks/Vault/src/main/java/com/bgsoftware/superiorskyblock/external/economy/EconomyProvider_Vault.java

@@ -11,6 +11,7 @@
 import org.bukkit.OfflinePlayer;
 import org.bukkit.plugin.RegisteredServiceProvider;
 
+import javax.annotation.Nullable;
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 
@@ -44,7 +45,7 @@ public EconomyResult depositMoney(SuperiorPlayer superiorPlayer, double amount)
         EconomyResponse economyResponse = econ.depositPlayer(offlinePlayer, amount);
         double moneyInTransaction = Precision.round(getMoneyInBank(offlinePlayer) - moneyBeforeDeposit, 3);
 
-        String errorMessage = moneyInTransaction == amount ? economyResponse.errorMessage :
+        String errorMessage = moneyInTransaction == amount ? getErrorMessageFromResponse(economyResponse) :
                 moneyInTransaction == 0 ? "You have exceed the limit of your bank" : "";
 
         return new EconomyResult(errorMessage, moneyInTransaction);
@@ -58,7 +59,7 @@ public EconomyResult withdrawMoney(SuperiorPlayer superiorPlayer, double amount)
         EconomyResponse economyResponse = econ.withdrawPlayer(offlinePlayer, amount);
         double moneyInTransaction = Precision.round(moneyBeforeWithdraw - getMoneyInBank(offlinePlayer), 3);
 
-        String errorMessage = moneyInTransaction == amount ? economyResponse.errorMessage :
+        String errorMessage = moneyInTransaction == amount ? getErrorMessageFromResponse(economyResponse) :
                 moneyInTransaction == 0 ? "Couldn't process the transaction" : "";
 
         return new EconomyResult(errorMessage, moneyInTransaction);
@@ -71,4 +72,9 @@ private double getMoneyInBank(OfflinePlayer offlinePlayer) {
         return Precision.round(econ.getBalance(offlinePlayer), 3);
     }
 
+    @Nullable
+    private static String getErrorMessageFromResponse(EconomyResponse economyResponse) {
+        return economyResponse.transactionSuccess() ? null : economyResponse.errorMessage;
+    }
+
 }