Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Butten in mealplan now toggles the selectionarea #138

Merged
merged 4 commits into from
Oct 16, 2021

Conversation

Toeffe3
Copy link
Member

@Toeffe3 Toeffe3 commented Oct 9, 2021

Purpose/Approach

Toggle visibility of meal plan creator

Testing steps to find bugs or errors in added code.

  1. Login
  2. Click Create to open the menu
  3. Click again it should now say "Cancel" and close
  • Menu opens
  • Menu closes
  • Button has propper text depending on change
  • Transition is good/acceptable

Related Issue

@Toeffe3 Toeffe3 requested a review from a team as a code owner October 9, 2021 12:18
@Toeffe3 Toeffe3 marked this pull request as draft October 9, 2021 12:22
@Toeffe3 Toeffe3 marked this pull request as ready for review October 9, 2021 12:35
@Toeffe3 Toeffe3 enabled auto-merge (squash) October 14, 2021 13:11
Copy link
Member

@Andreasgdp Andreasgdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you have the create meal plan menu opened and then click on cancel to close the menu, there is a small delay.

Expected behaviour would be that the transition starts the moment the user presses cancel, just like the transition starts as the user presses create to open the menu.

@Andreasgdp Andreasgdp self-requested a review October 16, 2021 10:18
@Toeffe3 Toeffe3 merged commit 199bc23 into master Oct 16, 2021
@Toeffe3 Toeffe3 deleted the issue-45-Toggle-create-menu branch October 16, 2021 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Toggle create menu
2 participants