Message notes cover all other messages again

[alelom]

Description:

We have again the same behaviour described in #480
that was fixed in #490.

Steps to reproduce:

Have any grasshopper component return a Note and additionally a Warning and/or an Error.
The Note colour will prevail, as described in #480.

Expected behaviour:

Note should not cover. Same behaviour obtained thanks to #490.

Test file(s):

[IsakNaslundBh]

Think this is working as expected on my machine. Using the testmethods produced by you alessio in #490 (review)

[alelom]

I'm basing this on a specific case I'm having:

here the component should turn orange, but it's not.

Before pulling out our hair, I'll do more tests asap.

[alelom]

Doing this action in Logging.cs, as suggested by @IsakNaslundBh:

solved the problem for me.

[adecler]

We have again the same behaviour described in #480
that was fixed in #490.

Checking the code on the master, it is exactly the same as it was after the fix in #490. Your own test confirms that the functionality hasn't changed.

@alelom , happy to make the change suggested but first you need to provide a test file that I can easily use to understand why your case is different than all the others.

@IsakNaslundBh , since you did the initial fix, any insight as to why the if-else is no longer relevant ? I assume it was added for a reason 😄

[IsakNaslundBh]

@alelom , happy to make the change suggested but first you need to provide a test file that I can easily use to understand why your case is different than all the others.

My thinking was that @alelom s case reached the logging method multiple times, so some notes had time to get added as remarks instead of blanks, so completely removing the If statement and only adding blanks with solve it.

@IsakNaslundBh , since you did the initial fix, any insight as to why the if-else is no longer relevant ? I assume it was added for a reason 😄

Forgot the reason yesterday, when I pinged the solution to alessio, but remember again today why it is done in that not so clean way. If a component only contains blank messages, it will not trigger the display of the bubble in the upper right corner, and not trigger the adding of remarks to the menu... So my suggested solution is no good.

Gah, only thing I can think of then is to check the component for any messages. Clear them and re-add them every time we add events. All for the sake of a faulty enum in GH...

[adecler]

@alelom , can you provide an example script that reproduces the bug ?

I have tested this with both the example you provide in #490 (review) and the Code Editor and it works as expected.

[alelom]

Please find below

https://burohappold.sharepoint.com/:u:/s/BHoM/EaLHWrCr9NVBoz76ubs8DKwBoU2QMt6dd6j4IE8EsbRoug?e=rYww0U

It's the last Execute component on the right.