Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miset_apparent_record_dimension_flag() 2nd param is broken #29

Closed
seanm opened this issue Jun 15, 2015 · 2 comments
Closed

miset_apparent_record_dimension_flag() 2nd param is broken #29

seanm opened this issue Jun 15, 2015 · 2 comments

Comments

@seanm
Copy link
Contributor

seanm commented Jun 15, 2015

I reported this on the list ages ago, but...

/libminc/libsrc2/dimension.c:638:3: Value stored to 'record_flag' is never read

I think that 2nd parameter should be a pointer, to return by reference...
@seanm
Copy link
Contributor Author

seanm commented Jun 18, 2015

Bert, and thoughts here?

@rdvincent
Copy link
Member

Will eliminating the store to record_flag work for now? This call has probably never been properly implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanm @rdvincent