Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable Windows Extensions crashes Visual Studio #63

Closed
furmangg opened this issue Apr 29, 2019 · 15 comments
Closed

Variable Windows Extensions crashes Visual Studio #63

furmangg opened this issue Apr 29, 2019 · 15 comments
Labels
bug

Comments

@furmangg
Copy link
Contributor

I downloaded and installed the new BIDS Helper beta last week after updating SSDT as instructed.

Up til now I have had no problems, though I didn't actually use any extensions. Today I used the Create Fixed Width Columns feature, I don't know if that is related.

Now, when I try to open the Variables page of a package, BIDS Helper crashes. This is in the application event log:

First error:

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.FileNotFoundException
at BIDSHelper.SSIS.VariablesWindowPlugin.RefreshHighlights()
at BIDSHelper.SSIS.VariablesWindowPlugin.grid_Invalidated(System.Object, System.Windows.Forms.InvalidateEventArgs)
at System.Windows.Forms.Control.OnInvalidated(System.Windows.Forms.InvalidateEventArgs)
at System.Windows.Forms.Control.NotifyInvalidate(System.Drawing.Rectangle)
at System.Windows.Forms.Control.Invalidate(Boolean)
at System.Windows.Forms.Control.Refresh()
at Microsoft.SqlServer.Management.UI.Grid.GridControl.UpdateGridInternal(Boolean)
at Microsoft.DataTransformationServices.Design.VariablesToolWindow+BaseDlgGridControl.UpdateGridInternal(Boolean)
at Microsoft.SqlServer.Management.UI.Grid.GridControl.UpdateGrid(Boolean)
at Microsoft.SqlServer.Management.UI.Grid.DlgGridControl.EndInit()
at Microsoft.DataTransformationServices.Design.GridColumnWidthManager.ResizeColumns()
at Microsoft.DataTransformationServices.Design.GridColumnWidthManager.gridControl_Resize(System.Object, System.EventArgs)
at System.Windows.Forms.Control.OnResize(System.EventArgs)
at System.Windows.Forms.Control.OnSizeChanged(System.EventArgs)
at Microsoft.SqlServer.Management.UI.Grid.GridControl.OnSizeChanged(System.EventArgs)
at System.Windows.Forms.Control.UpdateBounds(Int32, Int32, Int32, Int32, Int32, Int32)
at System.Windows.Forms.Control.UpdateBounds()
at System.Windows.Forms.Control.WmWindowPosChanged(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control.WndProc(System.Windows.Forms.Message ByRef)
at Microsoft.SqlServer.Management.UI.Grid.GridControl.WndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control+ControlNativeWindow.OnMessage(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.Control+ControlNativeWindow.WndProc(System.Windows.Forms.Message ByRef)
at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr, Int32, IntPtr, IntPtr)

Second error:

Faulting application name: devenv.exe, version: 15.9.28307.423, time stamp: 0x5c5b5342
Faulting module name: KERNELBASE.dll, version: 10.0.17763.348, time stamp: 0x53015794
Exception code: 0xe0434352
Fault offset: 0x0011c632
Faulting process id: 0x3204
Faulting application start time: 0x01d4feb467f49a40
Faulting application path: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\devenv.exe
Faulting module path: C:\Windows\System32\KERNELBASE.dll
Report Id: 3ec549f9-25a6-4a77-b321-d8b7548a8aea
Faulting package full name:
Faulting package-relative application ID:

I uninstalled the beta and reinstalled from within VS Extensions and Updates, which did not help. The error did not occur while BID Helper was uninstalled, but returned after it was reinstalled.

This version information was shown:

BIDS Helper Version shows v 2.3.1.0
SSDTBI 2019 (15.0.1200.68) for Visual Studio 2017 was detected.
SSDT Extensions Installed: SSAS (N/A), SSIS (2.2), SSRS (2.0)
Please upgrade SSRS to 2.5.6

I could not find SSRS 2.5.6, only 2.5.5 and 2.5.7. I installed 2.5.7

The version information is now:
BIDS Helper Version shows v 2.3.1.0
SSDTBI 2019 (15.0.1200.68) for Visual Studio 2017 was detected.
SSDT Extensions Installed: SSAS (N/A), SSIS (2.2), SSRS (2.5.7)

Now when I attempt to do a variety of things in VS, I get a BIDS Helper exception dialog. I'm going to paste in a graphic:

This appears every repeatedly when I click various things in VS, e.g., Open project in Solution explorer, open a package in a project, switch between the VS Variables, Error List, and Output windows, and others.

To summarize, before updating SSRS from 2.0 to 2.5.7, VS would crash when attempting to open the SSIS variables window, after updating to SSRS 2.5.7, the error message about is displayed many times.

I Using VS2017, here's the Help | About:

Microsoft Visual Studio Professional 2017
Version 15.9.7
VisualStudio.15.Release/15.9.7+28307.423
Microsoft .NET Framework
Version 4.7.03190

Installed Version: Professional

Microsoft Visual Studio Tools for Applications 2017 00369-60000-00001-AA386
Microsoft Visual Studio Tools for Applications 2017

BI Developer Extensions for Visual Studio 2017 2.3.1
BI Developer Extensions v2.3.1 for Visual Studio 2017 - An add-in to extend SQL Server Data Tools

C# Tools 2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools 1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

NuGet Package Manager 4.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.

PowerShell Pro Tools for Visual Studio 1.0
A set of tools for developing and debugging PowerShell scripts and modules in Visual Studio.

ProjectServicesPackage Extension 1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

ResourcePackage Extension 1.0
ResourcePackage Visual Studio Extension Detailed Info

ResourcePackage Extension 1.0
ResourcePackage Visual Studio Extension Detailed Info

SQL Server Data Tools 15.1.61901.24070
Microsoft SQL Server Data Tools

SQL Server Integration Services
Microsoft SQL Server Integration Services Designer
Version 15.0.1100.123

SQL Server Reporting Services 15.0.1331.137
Microsoft SQL Server Reporting Services Designers
Version 15.0.1331.137

Visual Basic Tools 2.10.0-beta2-63501-03+b9fb1610c87cccc8ceb74a770dba261a58e39c4a
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual Studio Code Debug Adapter Host Package 1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Thank you for your work on BIDS Helper.

Mike
.

Originally posted by @mpalandri in #50 (comment)
@furmangg
Copy link
Contributor Author

furmangg commented Apr 29, 2019 •
edited

@mpalandri I hope the crash is easy to workaround. Can you uninstall BI Developer Extensions then install this build attached below (unzip then install). It should swallow that exception so VS doesn't crash (if I read the stack trace right). It's a debug build so you will get lots of stuff in the Output window. If you spot any error messages in the Output window then feel free to copy the entire contents to this thread so I can troubleshoot further.

(debug build removed since it's outdated)

First question... does it fix the crash... second question, does the Variables window function as expected with the BI Developer Extensions additions...
https://bideveloperextensions.github.io/features/VariablesWindowExtensions/

@furmangg furmangg mentioned this issue Apr 29, 2019
Closed
furmangg pushed a commit that referenced this issue Apr 29, 2019
hopefully working around VS crash mentioned in issue #63
646bcef
@mpalandri
Copy link

mpalandri commented Apr 29, 2019 via email

@furmangg
Copy link
Contributor Author

Can you screenshot the error? Are there any errors in the Output window?

So now it doesn’t crash. But you are getting several error pop ups making it near unusable. Is that right?

@mpalandri
Copy link

mpalandri commented Apr 30, 2019 via email

@furmangg
Copy link
Contributor Author

Can you try again on the image?

@JornJorCon
Copy link

JornJorCon commented Apr 30, 2019 •
edited

This is my error when trying to open properties of an SSIS project. Worked fine until a few hours ago. (I guess when the updated version was installed automatically...)

Object reference not set to an instance of an object.

at BIDSHelper.SSIS.DeployPackagesPlugin.cmdButtonProperties_Click(CommandBarButton Ctrl, Boolean& CancelDefault) in C:\projects\BIDS Helper\GitHub\bideveloperextensions\SSIS\DeployPackagesPlugin.cs:line 515

OK

@furmangg
Copy link
Contributor Author

@JornJorCon please start a new issue if you could and include a screenshot of the Tools... BIDS Helper... Version tab. If it asks you to upgrade versions can you do that? I don’t have any reason to believe your issue is the same.

Thanks for the stack trace. I will fix that object reference not found error.

@mpalandri
Copy link

mpalandri commented Apr 30, 2019 via email

@mpalandri
Copy link

mpalandri commented Apr 30, 2019 via email

@furmangg
Copy link
Contributor Author

@mpalandri if you look at #63 your screenshot isn't showing. If you have a copy from when you reported it earlier, please do post so I can see whether this is a message box BI Developer Extensions is throwing or some built-in Visual Studio error message box.

I'm glad you can't repro it. The clue about it being a solution with multiple projects is helpful. We can do some further testing on that scenario. And once I see the message box we can look at ensuring that doesn't pop up but rather logs to the output window or something.

@mpalandri
Copy link

First screenshot of popup from yesterday:
bids

Second screenshot from this morning:

bids1

@mpalandri
Copy link

Sorry about the screen shots, I had been replying via email, which evidently doesn't work for embedded or attached image files.

Here's a bit more info. (Just when I think I found a pattern, things change)

After removing the debug version you sent me an installing the release version I was able to work for 30 mins or so before the error messagebox popped up, then kept popping up frequently as I described yesterdy. At that point I was not aware of any action I had performed that started it popping up again.

At that point I removed the release version an reinstalled the debug version you sent me. Again, I was able to work for several minutes before the error message started popping up again.

After closing and reopening VS, it still kept popping up.

I disabled the extension, then reenabled it. No error messagebox popups at first, then I clicked the Variables tab. The message popped up immediately, and now keeps popping up frequently, as it did yesterday.

I closed and reopened VS, the error messagebox kept popping up frequently.

To summarize:

After the extension is installed or reactivated after a deactivation, the error generally* does not occur until the Variables window is clicked.

After the error messagebox pops up the first time, it will continue to do so frequently, even if VS is closed and restarted.

Clicking on a task in the control flow seems to stop it popping up until I click in an open space in Solution explorer or on the control flow design surface.

  • I disabled and reenabled the debug version again, and this time the message started popping up without clicking on the variables window first.

furmangg pushed a commit that referenced this issue May 1, 2019
fix for issue #63
686e311 
Microsoft.DataWarehouse.Interfaces.DLL appears in the BIShared extension folder as version 15.0.0 but it also appears in the SSAS and SSRS extension folders as Microsoft.DataWarehouse.Interfaces.DLL with version 15.2.0.
@furmangg
Copy link
Contributor Author

furmangg commented May 1, 2019 •
edited

@mpalandri please uninstall BI Developer Extensions and install the following debug build. I believe I have the issue fixed. Please let me know if the Variables Window Extensions (a) doesn't crash and (b) functions properly where you can see the BI Developer Extensions buttons added to the toolbar at the top of that variables pane.

Edit: Beta build removed since it's not the latest

@mpalandri
Copy link

mpalandri commented May 1, 2019 via email

@furmangg furmangg added the bug label May 2, 2019
@furmangg
Copy link
Contributor Author

furmangg commented May 4, 2019

Release 2.3.2 includes this fix.

@furmangg furmangg closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@furmangg @mpalandri @JornJorCon