Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove default values to make entry can-be-deleted. #365

Merged
merged 3 commits into from
Jun 11, 2023
Merged

fix: remove default values to make entry can-be-deleted. #365

merged 3 commits into from
Jun 11, 2023

Conversation

fky2015
Copy link
Contributor

@fky2015 fky2015 commented Jun 10, 2023

@YDX-2147483647 可以测测。

@fky2015 fky2015 linked an issue Jun 10, 2023 that may be closed by this pull request
[Bug]: 模板注释中关于封面字段的描述与实际不符 #361
Closed
@YDX-2147483647
Copy link
Collaborator

YDX-2147483647 commented Jun 11, 2023 •
edited
Loading

我自己make了一下，结果和你一样；效果还是不完全和注释一致。

\BITSetup{} 注释 之前 现在
正常设置studentId = 11xxxxxxxx 正常显示 ✅正常学 号： 11xxxxxxxx ✅正常
删除 不显示 ❌显示默认值学 号： 3120211xxx（示例） ✅不显示
设为空studentId = {} 只显示下划线 ❌不显示 ❌不显示

图片

图片

图片

@fky2015
Copy link
Contributor Author

fky2015 commented Jun 11, 2023

那我直接改描述就好了！

@fky2015 fky2015 added this pull request to the merge queue Jun 11, 2023
Merged via the queue into main with commit c0a0d27 Jun 11, 2023
3 checks passed
@fky2015 fky2015 deleted the 361-bug-模板注释中关于封面字段的描述与实际不符 branch June 11, 2023 15:33
YDX-2147483647 added a commit to YDX-2147483647/BIThesis that referenced this pull request Jun 12, 2023
@YDX-2147483647
Merge remote-tracking branch 'upstream/main' into reading-report
9084485 
No need to overwrite default values now.

Relates-to: BITNP#365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YDX-2147483647 YDX-2147483647 YDX-2147483647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 模板注释中关于封面字段的描述与实际不符
2 participants
@fky2015 @YDX-2147483647