Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow inconsistent users #37

Merged
merged 3 commits into from
May 9, 2023
Merged

feat: Allow inconsistent users #37

merged 3 commits into from
May 9, 2023

Conversation

YDX-2147483647
Copy link
Contributor

@YDX-2147483647 YDX-2147483647 commented May 5, 2023 •
edited

  • Change the exception to a warning.
  • Use self.logged_in_user rather than self.username whenever possible.
  • Customize how warnings are shown. (Python doc: Replace with any callable by assigning to warnings.showwarning.)

Resolves #36

@YDX-2147483647 YDX-2147483647 added the enhancement New feature or request label May 5, 2023
@spencerwooo
Copy link
Member

Thanks, I'll review this ASAP.

spencerwooo
spencerwooo approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@spencerwooo spencerwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spencerwooo spencerwooo merged commit ee5608e into BITNP:main May 9, 2023
1 check passed
@YDX-2147483647 YDX-2147483647 deleted the logout branch September 17, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerwooo spencerwooo spencerwooo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

无法登出不是自己的账户
2 participants
@YDX-2147483647 @spencerwooo