Bug fixed and Laravel < 9 and Lumen compatibility removed #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdebacker
changed the title
|
Works for me, thanks! I also invited you to have write permissions. We're not doing a lot of Laravel dev at the moment so I'm happy for you to create releases yourself if you like! |
1 task
|
Ok, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before my previous PR, I tested the last version of Croppa in my local environment, it was working fine. But now that I begin to use it on a remote server, and I found that it was not working perfectly with Laravel 9 and Flysystem 3. So this pull request fixes the bugs I encountered. I also dropped the Laravel < 9 compatibility, forced to use Laravel Disks and updated the read me. Let me know what you think about all of that.