Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivot Position Sorting #74

Merged
merged 1 commit into from Aug 11, 2017
Merged

Pivot Position Sorting #74

merged 1 commit into from Aug 11, 2017

Conversation

arminulrich
Copy link

issue #73

getOtherKey was moved onto the Pivot Object in Laravel 5.4; by fetching the first Result we can directly access it. (in the position class there should always be a ->first() element)

@arminulrich
getOtherKey was moved onto the Pivot Object in Laravel 5.4; by fetchi…
8726816 
…ng the first Result we can directly access it. (in the position class there should always be a ->first() element)
@coveralls
Copy link

coveralls commented Aug 11, 2017 •
edited

Coverage Status

Coverage remained the same at 61.054% when pulling 8726816 on aulrich:laravel-5.4-relation-position-fix into 0c3ee07 on BKWLD:master.

@weotch weotch merged commit c93a073 into BKWLD:master Aug 11, 2017
@weotch
Copy link
Member

weotch commented Aug 11, 2017

Thanks!

@weotch weotch mentioned this pull request Aug 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arminulrich @coveralls @weotch