Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import custom directives from default blade compiler #25

Merged
merged 4 commits into from Aug 13, 2018
Merged

Import custom directives from default blade compiler #25

merged 4 commits into from Aug 13, 2018

Conversation

benallfree
Copy link
Contributor

Hi, here is a small PR to import custom directives from the default BladeCompiler. Some Laravel plugins like Ziggy add custom directives via

   $this->app['blade.compiler']->directive('routes', function ($group) {
      return "<?php echo app('" . BladeRouteGenerator::class . "')->generate({$group}); ?>";
    });

...but they are not picked up by laravel-haml because it is a separate BladeCompiler.

@benallfree
Copy link
Contributor Author

Nevermind. Service provider positioning accomplished this.

@benallfree benallfree closed this Aug 13, 2018
@benallfree
Copy link
Contributor Author

Sorry I was right the first time, reopening.

@benallfree benallfree reopened this Aug 13, 2018
@weotch weotch merged commit 4d2d673 into BKWLD:master Aug 13, 2018
@weotch
Copy link
Member

weotch commented Aug 13, 2018

Thanks! I tagged as 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants