Bump balance-text version from 3.2.1 to 3.3.1 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that was a mistake ... at leas the comment on 7e809dc doesn't make it sound like it was intentional. I'm gonna update this to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got my fix with
aria-hidden="true"merged intoadobe/balance-text, which is available starting with release 3.3.1.Note that this version bump (from 3.2.1 to 3.3.1) skips a release (3.3.0). Not sure if we were specifically avoiding that release or what.
I noticed this was pinned to an exact version (rather than ^), so I followed precedent and pinned this exact version too.
Tested this branch locally with
yarn-linkand it works well withyarn dev --spaandyarn generate.