Skip to content

Commit

Permalink
re-export digest and crypto_mac
Browse files Browse the repository at this point in the history
  • Loading branch information
oconnor663 committed Feb 4, 2020
1 parent 0c663aa commit 24071db
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/lib.rs
Expand Up @@ -58,7 +58,7 @@ pub mod portable;
#[doc(hidden)]
pub mod sse41;

mod traits;
pub mod traits;

This comment has been minimized.

Copy link
@WildCryptoFox

WildCryptoFox Feb 4, 2020

Unnecessary pub. Trait impls are global.

This comment has been minimized.

Copy link
@oconnor663

oconnor663 Feb 4, 2020

Author Member

This is because of the pub use re-exports added below. They'll be inaccessible if the module is not pub.

This comment has been minimized.

Copy link
@oconnor663

oconnor663 Feb 4, 2020

Author Member

As per #11 (comment).

This comment has been minimized.

Copy link
@WildCryptoFox

WildCryptoFox Feb 4, 2020

No, they won't be. Again, impls are global.

This comment has been minimized.

Copy link
@WildCryptoFox

WildCryptoFox Feb 4, 2020

Er. I misread this. Okay, the pub use re-exports are in the traits module. Crate re-exports are usually lib level.


use arrayref::{array_mut_ref, array_ref};
use arrayvec::{ArrayString, ArrayVec};
Expand Down
8 changes: 6 additions & 2 deletions src/traits.rs
@@ -1,5 +1,9 @@
//! Implementations for commonly used traits like `digest::Digest` and
//! `crypto_mac::Mac`.
//! Implementations of commonly used traits like
//! [`digest::Digest`](https://crates.io/crates/digest) and
//! [`crypto_mac::Mac`](https://crates.io/crates/crypto-mac).

pub use crypto_mac;
pub use digest;

use crate::{Hasher, OutputReader};
use digest::generic_array::{
Expand Down

0 comments on commit 24071db

Please sign in to comment.