Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blake3_neon.c on big-endian ARM #43

Open
oconnor663 opened this issue Jan 25, 2020 · 1 comment
Open

fix blake3_neon.c on big-endian ARM #43

oconnor663 opened this issue Jan 25, 2020 · 1 comment

Comments

@oconnor663
Copy link
Member

The current implementations of loadu_128 and storeu_128 use memcpy to read uint32x4_t vectors of e.g. hash input, which implicitly assumes the machine byte order is little-endian. My understanding is that that's true of most but not all ARM devices. We should figure out how to either make the code endianness-independent, or how to produce a compile-time error on big-endian ARM.

@Trendsetter74
Copy link

Trendsetter74 commented Jan 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants