Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot display images under WSL2 network location properly #7

Closed
BLumia opened this issue Aug 28, 2020 · 2 comments
Closed

Cannot display images under WSL2 network location properly #7

BLumia opened this issue Aug 28, 2020 · 2 comments

Comments

@BLumia
Copy link
Owner

BLumia commented Aug 28, 2020

When try to double-click image under WSL2 network location with path like \\wsl$\Ubuntu\home\username\filename.png, it will says "File is not a valid image".

When passing such path string to QUrl, it will drop the wsl$ hostname since the name is invalid. Unsurprisedly according to microsoft/WSL#4722 and dotnet/runtime#36595 .NET's System.Uri also describing network resource \\wsl$\ is invalid.

According to dotnet/runtime#36595 (comment) the WSL team is considering change of the name (as it violates spec), but before that happend, we can have a workaround fix for that, since wsl$ is still in used now and we don't know when the hostname change will happened and other application like GIMP and also Intellij IDEA can load files under network location like that properly.

BLumia added a commit that referenced this issue Aug 28, 2020
BLumia added a commit that referenced this issue Aug 28, 2020
BLumia added a commit that referenced this issue Aug 28, 2020
@BLumia BLumia closed this as completed in 9f67be6 Aug 28, 2020
@BLumia
Copy link
Owner Author

BLumia commented Aug 28, 2020

Basic support for WSL2 is now available in 0.3.1, still some known issues.

  • No prev and next image for WSL2 location image files. (probably in next release)
  • No drag and drop to load WSL2 location image file support. (due to QTBUG-86277, probably won't fix)

@BLumia
Copy link
Owner Author

BLumia commented Sep 29, 2020

Updates:

  • No prev and next image for WSL2 location image files: Should be fixed in e2fb181 in 0.3.2 release.
  • No drag and drop to load WSL2 location image file support: See this Qt Gerrit CR CR-314225, should be fixed when building with Qt 5.15.2, related patch removed in 01443d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant