Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.5.0 #13

Merged
merged 20 commits into from
Mar 14, 2024
Merged

Update to 1.5.0 #13

merged 20 commits into from
Mar 14, 2024

Conversation

kostrykin
Copy link
Member

@kostrykin kostrykin commented Mar 3, 2024

  • Refactor the code basis #11
    • Rename segmetrics.boundary to segmetrics.contour and related.
    • Move segmetrics.detection.COCOmAP to segmetrics.deprecated.COCOmAP.
    • Migrate testing dependencies from 7z to py7zr. 7z was not available on Conda/PIP, but py7zr is.
    • Refactor the code using flake8 and isort linters.
  • Add type hints #15
    • Minimum supported Python version is now 3.8
  • Add support for object-based Dice and other region-based measures #12
    • Replace the ObjectBasedDistanceMeasure class by the more general ObjectMeasureAdapter class
    • Add .object_based() method for all image-level measures.
    • Remove the argument and attribute mode of the Hausdorff distance.
    • Add .reversed() and .symmetric() methods for all asymmetric measures (e.g., object-based).
  • Add geometric-mean aggregation method #14
    • Add geometric-mean aggregation method.
    • Rename aggregation method obj-mean to object-mean.
  • Update documentation
  • Update docs/source/changelog.rst

* Rename `segmetrics.boundary` to `segmetrics.contour`

* Fix linting issues in study.py

* Fix isort linting issues

* Add linting job

* Fix linting issues

* Add isort config

* Fix linting issues in regional.py

* Fix linting issues in contour.py

* Migrate to `py7zr` instead of `7z` as a dependency

* Fix linting issues in measure.py

* Fix linting issues in detection.py, move `COCOmAP` to `segmetrics.deprecated`

* Omit deprecated.py from testing

* Fix linting issues in parallel.py

* Fix linting issues in cli.py

* Fix linting issues in study.py

* Fix linting issues
Add support for object-based Dice and other region-based measures
Copy link

github-actions bot commented Mar 3, 2024

Test coverage of this pull request: 88%

* Rename aggregation method `obj-mean` to `object-mean`

* Add `geometric-mean` aggregation method

* Fix linting issues

* Fix linting issues

* Fix tests
Copy link

github-actions bot commented Mar 3, 2024

Test coverage of this pull request: 88%

Copy link

github-actions bot commented Mar 3, 2024

Test coverage of this pull request: 88%

2 similar comments
Copy link

github-actions bot commented Mar 3, 2024

Test coverage of this pull request: 88%

Copy link

github-actions bot commented Mar 3, 2024

Test coverage of this pull request: 88%

Copy link

github-actions bot commented Mar 3, 2024

Test coverage of this pull request: 88%

* Add typing info

* Add type hints

* Fix linting issues

* Fix workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Fix dependencies

* Fix bug

* Fix Python 3.8 compatibility

* Fix typing

* Fix workflow

* Fix workflow

* Fix bug

* Fix bug

* Add more type hints

* [skip ci] Fix bug in `ObjectMeasureAdapter`

The correspondance cache is removed, since correspondances may differ between subsequent calls, now that `ObjectMeasureAdapter` is also used for region-based measures.

* [skip ci] Fix type hints

* Fix bug

* Fix issues

* Fix linting issues

* Add type hints for regional.py

* Add Literal types

* Update type hints

* Add type hints for contour.py

* Add type hints for detection.py

* Add `python>=3.8` requirement

* Fix requirements.txt

* Fix bug

* Add type hints for parallel.py
Copy link

Test coverage of this pull request: 86%

Copy link

Test coverage of this pull request: 86%

Copy link

Test coverage of this pull request: 86%

Copy link

Test coverage of this pull request: 86%

Copy link

Test coverage of this pull request: 86%

Copy link

Test coverage of this pull request: 86%

@kostrykin kostrykin marked this pull request as ready for review March 14, 2024 09:13
@kostrykin kostrykin merged commit 1f34b61 into master Mar 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant