wxWidgets debug trace left on

[Germano0]

Line codes

boinc/clientgui/BOINCGUIApp.cpp

Line 273 in 8c11cad

m_pLog->AddTraceMask(wxT("Function Start/End"));

boinc/clientgui/BOINCGUIApp.cpp

Line 274 in 8c11cad

m_pLog->AddTraceMask(wxT("Function Status"));

left wxWidgets debug trace on, so users get huge debug logs in ~/.BOINC folder.

Downstream bugreport https://bugzilla.redhat.com/show_bug.cgi?id=1347423

[ChristianBeer]

Those two lines are in the code since 2009. Are you sure you disabled the wxWidgets debugging when building the Manager for Fedora? They changed how debug mode works and you now have to build wxWidgets with -DNDEBUG to turn debug output off.

[Germano0]

Mmh a wxWidgets developer just told me that on wxWidgets > 3.x the debugtrace is enabled by default. This explains why in past we did not experience this problem
I solved addind the flag to line
http://pkgs.fedoraproject.org/cgit/rpms/boinc-client.git/tree/boinc-client.spec#n136

[LocutusOfBorg]

I guess the NDEBUG is something that upstream should export by default, I had to do the same patch in Debian

# Disable WXDEBUG assertions (avoiding e.g. https://bugs.debian.org/763113) -
# with -DNDEBUG these are quietly dealt with like they were with wx2.8.
export DEB_CPPFLAGS_MAINT_APPEND := -DNDEBUG

[ChristianBeer]

Well, this was indeed implemented upstream some time ago:
#1476 commits: 530eb18 and cc67f46
This only works if you use the ./configure file created by ./_autosetup of course. If this doesn't work let me know a place where I should change that upstream.

[LocutusOfBorg]

yes, now that I look at build logs, in Debian they are injected correctly (and then they were injected twice)