Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB layer enum functions are inconsistent #1813

Open
ChristianBeer opened this issue Mar 16, 2017 · 0 comments
Open

DB layer enum functions are inconsistent #1813

ChristianBeer opened this issue Mar 16, 2017 · 0 comments

Comments

@ChristianBeer
Copy link
Member

The basic enum* functions in html/inc/db_conn.inc support an argument for where and order clauses and the where clause must not start with "where". The table specific enum functions in html/inc/boinc_db.inc sometimes have one sometimes two arguments. See BoincProfile::enum and BoincCreditUser::enum.

This should be made consistent, as in: All table specific enum implementations should support two arguments. In addition a third argument for limit clauses should be added to the basic functions and the class implementations. This will make the DB layer more generic and will allow switching to something other than mysql in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant