Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team import partially broken (regression in e712c7af) #2850

Closed
brevilo opened this issue Nov 26, 2018 · 1 comment
Closed

Team import partially broken (regression in e712c7af) #2850

brevilo opened this issue Nov 26, 2018 · 1 comment

Comments

@brevilo
Copy link
Contributor

brevilo commented Nov 26, 2018

team_import.php won't create new users due to a missing/wrong include. The "code shuffle" in e712c7a was incomplete as it missed at least the file in question. Please use grep or whatever next time to avoid unnecessary bugs like this.

Since this bug has been present in BOINC for almost 1.5 years I expect it to be rather wide-spread and obviously the projects don't check their logs regularly - including us. OTOH, when fatal errors like this occur admins should be notified somehow. How to improve that?

Also, after fixing the missing include for the file above the whole web codebase needs to be checked for other potentially regressions caused by the incomplete commit.

@brevilo
Copy link
Contributor Author

brevilo commented Nov 26, 2018

Ok, that issue got fixed one month ago via ff156b5. Unfortunately that's a non-atomic commit so it can't directly be cherry-picked...

@brevilo brevilo closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant