Manager: adjust wxWidgets 3.1 compatibility #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxADJUST_MINSIZE was deprected with 2.6 and wxNB_FLAT was only used in 3.0 on Windows CE
Copied from https://github.com/wxWidgets/wxWidgets/blob/9a9ff290985c624d7933f1d33c8408f04c83a619/wxwin.m4 This in part reverts commit 51e2473 (Solaris specific CFLAGS and LIBS adjustments).
Since wxWidgets 3.1 the webview library is not in the dfault set of libraries and needs to be specified explicitly. Since it is optional for BOINC the wxWidgets detection macro needed to be augmented to allow optional libraries.
|
@ChristianBeer - Could you please test whether the workround in #2147 is still needed with wxWidgets 3.1? I've updated the report to describe in more detail the side-effects which are causing significant annoyance to some users. |
|
I've created a local build using this PR, latest master and wxWidgets 3.1. I got some extra tasks and will test the current behavior. Next step is to remove the workaround (locally) and see if that changes anything. |
|
It appears that the scrolling bug was a design failure in the BOINC code, unrelated to the wxWidgets bug the original commit intended to fix. Created separate pull request #3064 to handle the problem. |
JuhaSointusalo
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #2271
Alternate Designs
This solution fixes the problem at the source. The changes to the automake script were also pushed upstream to wxWidgets and got accepted for the next version (wxWidgets/wxWidgets#1256).
Release Notes
N/A