Converted all memset() deletions to conventional clearing methods #3363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3245
Description of the Change
The
memset()
function is used to delete certain structs by overwriting them with zeroes, this can be unsafe and causes the compiler to complain with a warning.This was solved by replacing memsets with empty struct initialisers where possible. There were some instances where
this
was being overwritten, and in this case, I had to createclear()
methods in each of the structs that had these memsets.Notes:
clear()
functions, namelyAPP_VERSION::clear()
ingui_rpc_client_ops.cpp
. Just a heads-up in-case this is bad, but I saw only good in doing this considering the previous implementation simply made the ptr = 0.Alternate Designs
N/A
Release Notes
Removed all object deletions using memset() and created conventional clearing functions