Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/scheduler: update NVidia detection again #4031

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Conversation

RichardHaselgrove
Copy link
Contributor

for new RTX 30x0 range released September 2020

Description of the Change

GFLOPS peak is under-reported by a factor of 2 on the new cards, compared with other reporting tools

Alternate Designs

I've been asked if we could use NvAPI_GPU_GetGpuCoreCount() instead (available since 2014), but rejected as a more complex modification which might break backwards compatibility.

Release Notes
Correct detection of NVidia RTX30x0 range GPUs

for new RTX 30x0 range released September 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #4031 (1600466) into master (24548b0) will decrease coverage by 10.28%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #4031       +/-   ##
============================================
- Coverage     16.66%   6.37%   -10.29%     
  Complexity      752     752               
============================================
  Files           134     276      +142     
  Lines         13131   35146    +22015     
  Branches       1492    1492               
============================================
+ Hits           2188    2241       +53     
- Misses        10827   32789    +21962     
  Partials        116     116               
Impacted Files Coverage Δ Complexity Δ
lib/coproc.cpp 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
sched/sched_limit.h 12.28% <0.00%> (-87.72%) 0.00% <0.00%> (ø%)
lib/msg_log.h 14.28% <0.00%> (-85.72%) 0.00% <0.00%> (ø%)
lib/sched_msgs.h 66.66% <0.00%> (-33.34%) 0.00% <0.00%> (ø%)
lib/sched_msgs.cpp 4.34% <0.00%> (-5.66%) 0.00% <0.00%> (ø%)
lib/msg_log.cpp 9.52% <0.00%> (-0.12%) 0.00% <0.00%> (ø%)
lib/parse.cpp 11.27% <0.00%> (-0.03%) 0.00% <0.00%> (ø%)
db/db_base.cpp 0.75% <0.00%> (-0.02%) 0.00% <0.00%> (ø%)
sched/credit.cpp 0.72% <0.00%> (-0.02%) 0.00% <0.00%> (ø%)
sched/sched_config.cpp 0.34% <0.00%> (-0.01%) 0.00% <0.00%> (ø%)
... and 158 more

@ChristianBeer
Copy link
Member

Close and reopen to trigger CI and provide current build artifacts

@ChristianBeer ChristianBeer reopened this Jan 15, 2021
@AenBleidd AenBleidd added this to In progress in BOINC Client/Manager via automation Jan 28, 2021
BOINC Client/Manager automation moved this from In progress to Reviewer approved Jan 28, 2021
@AenBleidd AenBleidd merged commit 51047f2 into master Feb 20, 2021
BOINC Client/Manager automation moved this from Reviewer approved to Done Feb 20, 2021
@RichardHaselgrove RichardHaselgrove deleted the RH_GPU_NVdetect2 branch March 9, 2021 12:15
@AenBleidd AenBleidd removed this from Done in BOINC Client/Manager Aug 4, 2021
@AenBleidd AenBleidd added this to In progress in Client Release 7.20.0 via automation Aug 4, 2021
@AenBleidd AenBleidd moved this from In progress to Done in Client Release 7.20.0 Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants