You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the problem
When a user is given a URL to attach to a BOINC project, it will not work if the case is not correct. For example: boincproject.com/boinc would work but boincproject.com/BOINC would not. Domain names are case-insensitive, and I see no reason for case-sensitive URL handling. There is a chance that a user without the correct case-sensitive URL may try to attach to a project and therefore have issues doing so. Making URL handling case-insensitive would eliminate this source of error and confusion.
This appears to be a problem for URLs with additional '/' after 'http(s)://'. I was able to reproduce this for projects such as Amicable Numbers and Rosetta@home, but not with Climateprediction.net or World Community Grid.
Error is "Project not found - The URL you supplied is not that of a BOINC-based project. Please check the URL and try again."
handle_project_attach() should call canonicalize_master_url() instead of massaging the URL itself.
canonicalize_master_url() should convert to lower case.
handle_project_attach() should call canonicalize_master_url() instead of massaging the URL itself. canonicalize_master_url() should convert to lower case.
I think I understand what you're saying for handle_project_attach(), sounds like the code should get simplified there. However, I'm not sure canonicalize_master_url() converts the url to lower case:
Describe the problem
When a user is given a URL to attach to a BOINC project, it will not work if the case is not correct. For example: boincproject.com/boinc would work but boincproject.com/BOINC would not. Domain names are case-insensitive, and I see no reason for case-sensitive URL handling. There is a chance that a user without the correct case-sensitive URL may try to attach to a project and therefore have issues doing so. Making URL handling case-insensitive would eliminate this source of error and confusion.
This is a further extension of #4801
I realize this is a small issue and there are more important ones, just wanted to raise it as an idea.
Describe the solution you'd like
Make BOINC server URL handling case-insensitive
The text was updated successfully, but these errors were encountered: