Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage_file_native.cpp issues #5392

Open
davidpanderson opened this issue Oct 8, 2023 · 3 comments
Open

stage_file_native.cpp issues #5392

davidpanderson opened this issue Oct 8, 2023 · 3 comments
Labels

Comments

@davidpanderson
Copy link
Contributor

Problems with this:

  1. It generates compile warnings (unused vars, shadowed vars)
  2. It has no comments or documentation
  3. the PR says it's a library function, but it has main() so it can't
    be used as a library function

Should this be removed?
It's redundant with the PHP script stage_file

@AenBleidd
Copy link
Member

This was added here: #4733

I believe, it's still useful to have it, so maybe we should just fix the issues and the documentation?

@davidpanderson
Copy link
Contributor Author

It's C++ code that does the same thing as existing PHP code.
If it's significantly faster maybe it's useful,
but it's not clear that it is faster.

@AenBleidd
Copy link
Member

I remember there was a reason for that. Just don't recall which exactly.
I'll try to find out and we can consider how to proceed with that later.

@AenBleidd AenBleidd added this to the Client/Manager milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants