Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo #46

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Fix Typo #46

merged 2 commits into from
Jul 30, 2022

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jul 19, 2022

Fix verification when you try to use scheme options "bip48//1h", "bip48//2h" and "bip43/{purpose}h"

@crisdut crisdut force-pushed the fix/typo branch 2 times, most recently from 5781e1e to 2067f29 Compare July 19, 2022 01:57
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you pls remove all PR-unrelated formatting changes (for instance by reverting them or doing cargo +nightly fmt and amending the commit with the result)?

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ACK 8ad83b8

It actually also required a re-base, but I managed to get changes from the master merged here with a dedicated commit

@dr-orlovsky dr-orlovsky merged commit 9bf83a1 into BP-WG:master Jul 30, 2022
@crisdut crisdut deleted the fix/typo branch November 24, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants