Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Power gate #236

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Power gate #236

wants to merge 9 commits into from
+286 −0

Conversation

ermalrrapaj
Copy link

Added the power gate class and also included tests.

edyounis
edyounis requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@edyounis edyounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Before we merge this into main, can you fix the pre-commit issues? They don't seem serious, but let me know if you need any help. The tests are also failing, we should take a look at those.

@edyounis edyounis requested a review from jkalloor3 July 22, 2024 20:55
edyounis
edyounis previously approved these changes Jul 22, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edyounis edyounis edyounis left review comments

@jkalloor3 jkalloor3 Awaiting requested review from jkalloor3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ermalrrapaj @edyounis