DT_NEEDED not listed for ELF32 files.

[e5150]

On line 504 getlibraries() in elfls.c:
count = proghdr[i].p_filesz / sizeof *dyns;
Where sizeof(*dyns) == sizeof(Elf64_Dyn). Given a 32-bit ELF file, where count is half of what it's supposed to be, given sufficiently many dynamic sections, DT_STRSZ or DT_STRTAB might be beyond the erronuous count, and getlibraries returns 0 prematurely, without listings any needed libraries.

[BR903]

Good catch. I've submitted a fix.

[e5150]

The new version segfaults on me, due to the dyns = malloc on the new line 504 not allocating enough for 32-bit files, since p_filesz is count * sizeof(Elf32_Dyn), but dyns needs to hold count number of Elf64_Dyn.
Allocating p_filesz * 2 solves the issue, but is rather ugly…

[BR903]

The new version segfaults on me, due to the dyns = malloc on the
new line 504 not allocating enough for 32-bit files, since
p_filesz is count * sizeof(Elf32_Dyn), but dyns needs to hold
count number of Elf64_Dyn. Allocating p_filesz * 2 solves the
issue, but is rather ugly?

Ugh! I must have messed up my test somehow.

[BR903]

I've submitted a replacement fix. Less elegant, but this one actually works.

[e5150]

Yes, now I'm getting the expected results on the files that first brought the issue to light.
Thanks!