Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to the Installation page #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hfoletto
Copy link

This PR adds more details to the installation page. The main 2 points are:

  1. Instructions on how to create the auth.js file and how it should look like
  2. Specifying the package version when running the composer require command.

When I tried to just run composer require brackets/craftable-pro it failed, saying it could not be downloaded. At first glance I thought it was a problem with my authentication strategy, however, after inspecting, I see that it tried to install a different version, dev-feat/ziggy2:
image

Specifying a version compatible with 2.0 resolves this problem.

@hfoletto hfoletto changed the title Add more details to the installation.mdx page Add more details to the installation page May 21, 2024
@hfoletto hfoletto changed the title Add more details to the installation page Add more details to the Installation page May 21, 2024
@palypster palypster requested a review from strstensky May 21, 2024 14:35
@palypster
Copy link
Contributor

Thank you for your suggestion <3 we'll have a look internally and get back to you. If it's okay, we'll merge it soon. It's weird that composer doesn't install v2 by default - need to investigate this as well. Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants