Add support for explode #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbingner thanks a lot for the PR, and sorry for not reviewing it before. Linter is failing because of the comment. I will update a better lint rule so that we can execute the tests and merge this PR |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@all-contributors please add @sbingner for code |
|
I've put up a pull request to add @sbingner! 🎉 |
kevinccbsg
approved these changes
Apr 7, 2022
|
@sbingner it would be great to include a test. We will try to include it before doing the release for both PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Description:
Adds support for explode