-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: schema type casing #221
fix: schema type casing #221
Conversation
Update logic for type application casing to ensure lowercase.
Found another location of |
Update logic for type application casing to ensure lowercase.
Update logic for type application casing to ensure lowercase.
Kudos, SonarCloud Quality Gate passed!
|
@kevinccbsg or @bri06 or @LonelyPrincess Could you please clarify who would be a good member to review this PR? Or if anything additionally is needed for it to be ready for review? Thanks. |
This looks fine to me! The PR description is pretty clear, and doesn't seem like we would be missing anything to consider it complete. I've approved it, although will wait for @kevinccbsg to give the OK before merging. Thanks for your contribution! 😉 |
Thanks for reviewing @LonelyPrincess !! @alexstaroselsky we will do a relases asap. |
@all-contributors please add @alexstaroselsky for code |
I've put up a pull request to add @alexstaroselsky! 🎉 |
Thanks all for helping get this through. @kevinccbsg can you confirm when this would be tentatively scheduled for release? If there are other features waiting for review/approval that would delay it, could there be a beta publish for testing? |
@alexstaroselsky sorry for the delay Today we will do a release. |
Update logic for type application casing to ensure lowercase.
What kind of change does this PR introduce? (check at least one)
Description:
When types such as
Array<Song>
orSong[]
are used, thetype
for the property resolves to'Array'
rather than the officially support OpenAPI data type of'array'
. When the type is'Array'
, the OpenAPI document does not correctly recognize the property as a valid array. The officially supported types are lowercase anyway: