Skip to content

Commit

Permalink
Fix team error detection.
Browse files Browse the repository at this point in the history
  • Loading branch information
BSalita committed Sep 8, 2023
1 parent 0e5205e commit ba04207
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 4 additions & 1 deletion chatlib/chatlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def get_club_results_details_data(url):
elif soup.find('result-details'):
data = soup.find('result-details')['v-bind:data']
elif soup.find('team-result-details'):
data = soup.find('team-result-details',attrs='v-bind:data')
return None # todo: handle team events
data = soup.find('team-result-details')['v-bind:data']
else:
assert False, "Can't find data tag."
assert data is not None and isinstance(data,str) and len(data), [url, data]
Expand Down Expand Up @@ -198,6 +199,8 @@ def json_dict_to_types(json_dict,root_name,path):

def create_dfs(acbl_number,event_url):
data = get_club_results_details_data(event_url)
if data is None:
return None
dfs = {}
dfs['event'] = pd.json_normalize(data,max_level=0)
for k,v in dfs['event'].items():
Expand Down
2 changes: 2 additions & 0 deletions release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
## Prompt Notes
1. Does chat understand overtricks, justmade, undertricks? Or should result be used?
2. Document SD_[Score,ParScore,Matchpoints,Pct][Max][Diff].
3. Implement stats in https://stats.lovebridge.com/statistics/lb_02_107602 --

## To Be Implemented
1. Is there some way that logo url can be file:///assets/...?
Expand Down Expand Up @@ -51,6 +52,7 @@
14. implement rankings. can this be done using a prompt or must webpage be scrapped?
15. Overall and directional rankings. Or can this be done using a prompt?
16. Show rank of best declarers, best defenders (boards we declared).
17. Implement freqs of who's declarer, defender, and dummy.
18. Show list of prompts in Help tab.

## Column Issues
Expand Down

0 comments on commit ba04207

Please sign in to comment.