-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoW retargeting change for BTG hard fork permine proid. #2
Conversation
- Fork from block #487427. - Premine 16000 blocks. - Minimal difficulty for the premining peroid.
@@ -15,9 +15,15 @@ unsigned int GetNextWorkRequired(const CBlockIndex* pindexLast, const CBlockHead | |||
assert(pindexLast != nullptr); | |||
unsigned int nProofOfWorkLimit = UintToArith256(params.powLimit).GetCompact(); | |||
|
|||
// Only change once per difficulty adjustment interval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you need me to fill this in?
not sure if missing or if params call for this syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't get it. I basically added a condition to handle premine period. That's saying, the difficulty will be forced to lower bound if the height of the next block is between [BTGHeight, BTGHeight + BTGPremineWindow].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats this premine for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty large premine, reddit is in an uproar and calling this project a scam because of this. I would think twice on this guys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello guys! Please check this pull request - https://github.com/h4x3rotab/BTCGPU/pull/1/files . This code for the premining has been made a month ago and a week after the concept was changed. Please have in mind that a premining is being discussed and if there is one, it will be completely transparent to everyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StarbuckBG Okay, how about transparency on exactly which block the fork will occur? Or did that happen already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like to give about 150kzols hashing power. how can i support your directly during the pre-mine stage?
@@ -271,6 +275,8 @@ class CRegTestParams : public CChainParams { | |||
consensus.BIP34Hash = uint256(); | |||
consensus.BIP65Height = 1351; // BIP65 activated on regtest (Used in rpc activation tests) | |||
consensus.BIP66Height = 1251; // BIP66 activated on regtest (Used in rpc activation tests) | |||
consensus.BTGHeight = 100000000; // Not activated yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the height for regression test mode. As we didn't write a regression test for the hard fork yet, I left it a very large number. Thought?
@@ -79,6 +79,8 @@ class CMainParams : public CChainParams { | |||
consensus.BIP34Hash = uint256S("0x000000000000024b89b42a942fe0d9fea3bb44ab7bd1b19115dd6a759c0808b8"); | |||
consensus.BIP65Height = 388381; // 000000000000000004c2b624ed5d7756c508d90fd0da2c7c679febfa6c4735f0 | |||
consensus.BIP66Height = 363725; // 00000000000000000379eaa19dce8c9b722d46ae6a57c2f1a988119488b50931 | |||
consensus.BTGHeight = 487427; // Around 10/1/2017 12:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
做得好 , 完美的身高!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 :)
Respect the time and the efforts of the developers!
…Sent from my iPhone 7 plus
On Oct 7, 2017, at 4:39 AM, Andrew Njoo ***@***.***> wrote:
@adnjoo commented on this pull request.
In src/pow.cpp:
> @@ -15,9 +15,15 @@ unsigned int GetNextWorkRequired(const CBlockIndex* pindexLast, const CBlockHead
assert(pindexLast != nullptr);
unsigned int nProofOfWorkLimit = UintToArith256(params.powLimit).GetCompact();
- // Only change once per difficulty adjustment interval
PREMINE SUCKS
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Bobby, it is being discussed. That large premine was just an idea, and it was completely rejected from the beginning. I will make a pull request with the required changes tomorrow.
… On 9 Oct 2017, at 23:23, Bobby G Roberts ***@***.***> wrote:
@BobbyGR commented on this pull request.
In src/pow.cpp <#2 (comment)>:
> @@ -15,9 +15,15 @@ unsigned int GetNextWorkRequired(const CBlockIndex* pindexLast, const CBlockHead
assert(pindexLast != nullptr);
unsigned int nProofOfWorkLimit = UintToArith256(params.powLimit).GetCompact();
- // Only change once per difficulty adjustment interval
This is a pretty large premine, reddit is in an uproar and calling this project a scam because of this. I would think twice on this guys.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrUYXA8ItaHoxUITf1JeXevWL3vdkks5sqoC4gaJpZM4POvp9>.
|
Is this a joke, or is there actually an October 1st pre-mine, and does this mean that people buying bitcoins and holding them until after the supposed October 25th fork date now wouldn't be entitled to their bitcoin gold coins? |
It's not difficult to tell whether a Britney gif is a joke or not, but it apparently is difficult for people outside of this project to read the code and read the devs' intentions. So, people are still wondering what all this talk about a permine/premine proid/peroid is. @StarbuckBG , what are the "required changes" -- to remove any premine code? |
To be super clear Britney is confused as to whether this is an elaborate hoax or if she could be a victim if a replay attack. She is on live TV so she isn't sure if she should ask someone who may be trying to scam her or if she should just ignore btc gold altogether |
If there is premining it will be made transparently and all of the community will be able to see how it is done. Currently there is no premining ongoing. You can download build and run the current code or the fork made by h4x. We are still working hard to provide the core, because there are some stuff that still needs to be implemented. The current premining code will be removed in the Pull Request that I’m doing now, so everyone are sure what is going on.
…Sent from my iPhone 7 plus
On Oct 10, 2017, at 8:00 AM, mmortal03 ***@***.***> wrote:
It's not difficult to tell whether a Britney gif is a joke or not, but it apparently is difficult for people outside of this project to read the code and read the devs' intentions. So, people are still wondering what all this talk about a permine/premine proid/peroid is. @StarbuckBG , what are the "required changes" -- to remove any premine code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This will happen on October 25. The exact block is TBD. We are discussing it right now.
… On 11 Oct 2017, at 9:34, CBScott ***@***.***> wrote:
@CBScott commented on this pull request.
In src/pow.cpp <#2 (comment)>:
> @@ -15,9 +15,15 @@ unsigned int GetNextWorkRequired(const CBlockIndex* pindexLast, const CBlockHead
assert(pindexLast != nullptr);
unsigned int nProofOfWorkLimit = UintToArith256(params.powLimit).GetCompact();
- // Only change once per difficulty adjustment interval
@StarbuckBG <https://github.com/starbuckbg> Okay, how about transparency on exactly which block the fork will occur? Or did that happen already?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrWpfwhNKLuxaTCZnYYFmLf-Bm06Bks5srGF9gaJpZM4POvp9>.
|
okay, cool... can't wait to sell my BTG and be done with this shit |
The thing you are saying is really bad. You shall read more about BTG, and then you will change your point of view. Why you are posting here, asking information and then say, ok I’ll just sell it…
… On 11 Oct 2017, at 9:36, CBScott ***@***.***> wrote:
okay, cool... can't wait to sell BTG and be done with this shit
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrT9tjWnNwQkIjRY8hK5sM-hfnHVbks5srGHmgaJpZM4POvp9>.
|
Well let's go over this... Bitcoin Gold was already a failed ICO... then the pre-mine idea which quickly came under criticism... what good is this coin actually doing by coming into existence? What purpose does this fork serve other than the selfish desires of a few? The only benefit that comes from BTG is holding it until the price peaks and selling before it goes the ever declining path of Bitcoin Cash.. |
There was no ICO (: All of the misleading information was spread by third parties that are loosing money from the rising BTC. And the good is that you have SegWit, each block diff adjustment, replay protection .. And is mined using Video Cards, not using ASICs and making factories with ASICs.
… On 11 Oct 2017, at 9:43, CBScott ***@***.***> wrote:
Well let's go over this... Bitcoin Gold was already a failed ICO... then the pre-mine idea which quickly came under criticism... what good is this coin actually doing by coming into existence? What purpose does this fork serve other than the selfish desires of a few?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrVadeUcsj_HcxtvrizPTaxRN65b3ks5srGOFgaJpZM4POvp9>.
|
@StarbuckBG Then explain this shit... https://web.archive.org/web/20170831032225/http://btcgpu.org/ |
What "3rd parties" are losing money from the rising BTC price? anyone with a brainstem knows how to play this... |
"And is mined using Video Cards, not using ASICs and making factories with ASICs" Not sure how that's relevant |
It is shown in the URL : Web.archive.org, this is old snapshot that was published in the very beginning even when I was not in the project. When I came this idea was not even disputed as it has been denied immediately after starting work on the project. ICO for a Bitcoin is something that is breaking all the principals of Decentralization. This idea, and the large primine idea are not valid single 1 os september, the day the development started. You can see the press release, and I’m telling you the facts.
… On 11 Oct 2017, at 9:48, CBScott ***@***.***> wrote:
@StarbuckBG <https://github.com/starbuckbg> Then explain this shit... https://web.archive.org/web/20170831032225/http://btcgpu.org/ <https://web.archive.org/web/20170831032225/http://btcgpu.org/>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrSctcT0eZ5cmOnoXZyLSO5KnRF9sks5srGTCgaJpZM4POvp9>.
|
You have to know the success or failure of a coin really only has to do with it's popularity at this point right? "this is old snapshot that was published in the very beginning even when I was not in the project." So how does your specific presence change that this was a failed ICO? "You can see the press release, and I’m telling you the facts." That's cool and all but you aren't really inspiring optimism regarding the future of this clearly underdeveloped, soon to be failed, BTC wannabe, GPU mineable, altcoin... which will likely be scraping the lower side of the charts on exchanges by Christmas |
Everyone is free to provide opinion. We as a team believe that this is an alt coin that has future. This is the reason why we are working 60 hours a week and do our best to provide best possible solution.
… On 11 Oct 2017, at 9:56, CBScott ***@***.***> wrote:
You have to know the success or failure of a coin really only has to do with it's popularity at this point right?
"this is old snapshot that was published in the very beginning even when I was not in the project."
So how does your specific presence change that this was a failed ICO?
"You can see the press release, and I’m telling you the facts."
That's cool and all but you aren't really inspiring optimism regarding the future of this clearly underdeveloped, soon to be failed, BTC wannabe, GPU mineable, altcoin... which will likely be scraping the lower side of the charts on exchanges by Christmas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADrjrU-O0ZUYdKJunuXeF7en397mqFJcks5srGangaJpZM4POvp9>.
|
No matter how you look at these things. BTC is BTC, you can't fork btc and it still be bitcoin (because the bitcoin chain is what makes bitcoin bitcoin) not when you're running on a separate chain :P, thus it's an altcoin period after that. everybody knows this who's been in crypto for some time :) |
"We as a team believe..." Belief is the absence of fact |
bitcoinGold will not replace BTC @CBScott , as did not BCH. no reason to tear these guys apart on principles. let them release this coin, we make our free $ and move on :) |
Oh yeah, sure... I'll just give them a pass on their shortcomings and the fact that their eyes are clearly bigger than their stomach on this project "bitcoinGold will not replace BTC @CBScott" Yeah, that's what I said... "we make our free $ and move on :)" Hey I suggested that, but he pushed the issue, I just responded in kind |
Believe is the only thing that can make you do a job the best possible way! Not money, not need, just a belief ;)
…Sent from my iPhone 7 plus
On Oct 11, 2017, at 10:01 AM, CBScott ***@***.***> wrote:
"We as a team believe..."
Belief is the absence of fact
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
And BTW who is saying that bitcoin is not good? It is well made, secure, working. The problem is not with the Bitcoin, the problem is wI h the Chinese factories that do 60% of the mining :) this is the thing we don’t like.
…Sent from my iPhone 7 plus
On Oct 11, 2017, at 10:07 AM, CBScott ***@***.***> wrote:
Oh yeah, sure... I'll just give them a pass on their shortcomings and the fact that their eyes are clearly bigger than their stomach on this project
"bitcoinGold will not replace BTC @CBScott"
Yeah, that's what I said...
"we make our free $ and move on :)"
Hey suggested that, but he pushed the issue, I just responded in kind
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I'd bet you would have voted for Bernie Sanders if you could have... -_- |
Why do you guys need so much premine? How to justify 200,000 BTG for the 'developer team'? |
Ignore the trolls StarbuckBG who are only in it for the money and have no understanding of what Bitcoin represents. I think this will help all of you understand BTG a bit better and how we should be supporting this coin: https://squawker.org/technology/bitcoin-gold-hard-fork-simplified/ |
@uireloading you joined GitHub two days ago so you might not be aware but the reason projects like this one are open source is so that anyone can comment on and question legitimacy of things, including decisions that have a huge impact on the community. And not sure what you mean by "only in it for the money" but you realize that Bitcoin is a currency, correct? It literally is money and if you aren't in this for Bitcoin then... |
i would like to give about 150kzols hashing power. how can i support your directly during the pre-mine stage? |
@krtschmr hashing power is not necessary for premining stage at all. "Premaining" mean exclusive access to the blockchain branch. |
Well, you could consider premining to be the very beginning it is released. In my mind this isn't "pre" mining. It's just a case of "early bird gets the worm". In that case it matters if you have a lot of hashing power. The faster you can mine before others the more 💰 you'll make. |
That's not how it works, it's not really "pre-mining" because no one else is competing for the blocks and the blocks are available on the BTC blockchain so they are basically just taking everyone else's hashing power and plucking it and just putting it in their wallets. First sign of a scam. |
Yeah, it's more like an instamine stash than a premine. |
@mmortal03 do you know of any other coins which have done an "instamine stash" ? I would be interested to compare |
Dash has been accused of doing an instamine, for instance, but, actually, I think I had a brain fart earlier -- this is a premine, but it's not clear to me that they're even having to use hash power to mine it (which is what I was getting caught up on), but I don't think that really matters much in the end -- they're still essentially just giving themselves money. |
Am I incorrect in this assessment? You are asking for yourselves, 200,000BTG as rewarded cache of coin supply for developing the fork. 200,000 coins is 200,000/16.6 million BTC in circulation today. Or about 1.2% of the supply of the currency. Doesn't that seem excessive to anyone or am I misunderstanding something about how supply is changing hands between the two sides of the fork? Even if significant mining resources get committed to the fork to increase supply, for some time you would essentially own 1.2% of the currency. |
Congrats ! seems like the values defended by Satoshi are gone :/ |
I hope you decide to donate the Premine to charity instead of using it for yourself selfishly. |
Guys, this is an issue tracker. If you have an issue that is not programming related, there are other places to discuss that. |
@dan-klasson it is right place to discuss dev decisions. |
Set PremineWindow to 16000
sync with master
This is the very early commit and the premine details have been changed. Check our roadmap.