Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoW retargeting change for BTG hard fork permine proid. #2

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

h4x3rotab
Copy link
Member

@h4x3rotab h4x3rotab commented Sep 6, 2017

  • Fork from block #487427 (Oct. 1st, 12:00 UTC).
  • Premine 16000 blocks.
  • Minimal difficulty for the premining peroid.

This is the very early commit and the premine details have been changed. Check our roadmap.

- Fork from block #487427.
- Premine 16000 blocks.
- Minimal difficulty for the premining peroid.
@@ -15,9 +15,15 @@ unsigned int GetNextWorkRequired(const CBlockIndex* pindexLast, const CBlockHead
assert(pindexLast != nullptr);
unsigned int nProofOfWorkLimit = UintToArith256(params.powLimit).GetCompact();

// Only change once per difficulty adjustment interval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you need me to fill this in?
not sure if missing or if params call for this syntax

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't get it. I basically added a condition to handle premine period. That's saying, the difficulty will be forced to lower bound if the height of the next block is between [BTGHeight, BTGHeight + BTGPremineWindow].

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats this premine for?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty large premine, reddit is in an uproar and calling this project a scam because of this. I would think twice on this guys.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello guys! Please check this pull request - https://github.com/h4x3rotab/BTCGPU/pull/1/files . This code for the premining has been made a month ago and a week after the concept was changed. Please have in mind that a premining is being discussed and if there is one, it will be completely transparent to everyone.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StarbuckBG Okay, how about transparency on exactly which block the fork will occur? Or did that happen already?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to give about 150kzols hashing power. how can i support your directly during the pre-mine stage?

@@ -271,6 +275,8 @@ class CRegTestParams : public CChainParams {
consensus.BIP34Hash = uint256();
consensus.BIP65Height = 1351; // BIP65 activated on regtest (Used in rpc activation tests)
consensus.BIP66Height = 1251; // BIP66 activated on regtest (Used in rpc activation tests)
consensus.BTGHeight = 100000000; // Not activated yet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the height for regression test mode. As we didn't write a regression test for the hard fork yet, I left it a very large number. Thought?

@@ -79,6 +79,8 @@ class CMainParams : public CChainParams {
consensus.BIP34Hash = uint256S("0x000000000000024b89b42a942fe0d9fea3bb44ab7bd1b19115dd6a759c0808b8");
consensus.BIP65Height = 388381; // 000000000000000004c2b624ed5d7756c508d90fd0da2c7c679febfa6c4735f0
consensus.BIP66Height = 363725; // 00000000000000000379eaa19dce8c9b722d46ae6a57c2f1a988119488b50931
consensus.BTGHeight = 487427; // Around 10/1/2017 12:00 UTC
Copy link
Contributor

@lrgeoemtry lrgeoemtry Sep 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

做得好 , 完美的身高!!

Copy link
Contributor

@lrgeoemtry lrgeoemtry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 :)

@h4x3rotab h4x3rotab merged commit 6b4e56d into BTCGPU:master Sep 12, 2017
@martin-key
Copy link
Collaborator

martin-key commented Oct 7, 2017 via email

@martin-key
Copy link
Collaborator

martin-key commented Oct 9, 2017 via email

@mmortal03
Copy link

Is this a joke, or is there actually an October 1st pre-mine, and does this mean that people buying bitcoins and holding them until after the supposed October 25th fork date now wouldn't be entitled to their bitcoin gold coins?

@plwalters
Copy link

Alt Text

@mmortal03
Copy link

It's not difficult to tell whether a Britney gif is a joke or not, but it apparently is difficult for people outside of this project to read the code and read the devs' intentions. So, people are still wondering what all this talk about a permine/premine proid/peroid is. @StarbuckBG , what are the "required changes" -- to remove any premine code?

@plwalters
Copy link

To be super clear Britney is confused as to whether this is an elaborate hoax or if she could be a victim if a replay attack. She is on live TV so she isn't sure if she should ask someone who may be trying to scam her or if she should just ignore btc gold altogether

@martin-key
Copy link
Collaborator

martin-key commented Oct 10, 2017 via email

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@CBScott
Copy link

CBScott commented Oct 11, 2017

okay, cool... can't wait to sell my BTG and be done with this shit

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@CBScott
Copy link

CBScott commented Oct 11, 2017

Well let's go over this... Bitcoin Gold was already a failed ICO... then the pre-mine idea which quickly came under criticism... what good is this coin actually doing by coming into existence? What purpose does this fork serve other than the selfish desires of a few? The only benefit that comes from BTG is holding it until the price peaks and selling before it goes the ever declining path of Bitcoin Cash..

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@CBScott
Copy link

CBScott commented Oct 11, 2017

@StarbuckBG Then explain this shit... https://web.archive.org/web/20170831032225/http://btcgpu.org/

@CBScott
Copy link

CBScott commented Oct 11, 2017

What "3rd parties" are losing money from the rising BTC price? anyone with a brainstem knows how to play this...

@CBScott
Copy link

CBScott commented Oct 11, 2017

"And is mined using Video Cards, not using ASICs and making factories with ASICs"

Not sure how that's relevant

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@CBScott
Copy link

CBScott commented Oct 11, 2017

You have to know the success or failure of a coin really only has to do with it's popularity at this point right?

"this is old snapshot that was published in the very beginning even when I was not in the project."

So how does your specific presence change that this was a failed ICO?

"You can see the press release, and I’m telling you the facts."

That's cool and all but you aren't really inspiring optimism regarding the future of this clearly underdeveloped, soon to be failed, BTC wannabe, GPU mineable, altcoin... which will likely be scraping the lower side of the charts on exchanges by Christmas

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@DemonRx
Copy link
Contributor

DemonRx commented Oct 11, 2017

No matter how you look at these things. BTC is BTC, you can't fork btc and it still be bitcoin (because the bitcoin chain is what makes bitcoin bitcoin) not when you're running on a separate chain :P, thus it's an altcoin period after that. everybody knows this who's been in crypto for some time :)

@CBScott
Copy link

CBScott commented Oct 11, 2017

"We as a team believe..."

Belief is the absence of fact

@DemonRx
Copy link
Contributor

DemonRx commented Oct 11, 2017

bitcoinGold will not replace BTC @CBScott , as did not BCH. no reason to tear these guys apart on principles. let them release this coin, we make our free $ and move on :)

@CBScott
Copy link

CBScott commented Oct 11, 2017

Oh yeah, sure... I'll just give them a pass on their shortcomings and the fact that their eyes are clearly bigger than their stomach on this project

"bitcoinGold will not replace BTC @CBScott"

Yeah, that's what I said...

"we make our free $ and move on :)"

Hey I suggested that, but he pushed the issue, I just responded in kind

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@martin-key
Copy link
Collaborator

martin-key commented Oct 11, 2017 via email

@CBScott
Copy link

CBScott commented Oct 11, 2017

I'd bet you would have voted for Bernie Sanders if you could have... -_-

@adnjoo
Copy link

adnjoo commented Oct 11, 2017

Why do you guys need so much premine? How to justify 200,000 BTG for the 'developer team'?

@uireloading
Copy link

uireloading commented Oct 11, 2017

Ignore the trolls StarbuckBG who are only in it for the money and have no understanding of what Bitcoin represents. I think this will help all of you understand BTG a bit better and how we should be supporting this coin:

https://squawker.org/technology/bitcoin-gold-hard-fork-simplified/

@plwalters
Copy link

@uireloading you joined GitHub two days ago so you might not be aware but the reason projects like this one are open source is so that anyone can comment on and question legitimacy of things, including decisions that have a huge impact on the community.

And not sure what you mean by "only in it for the money" but you realize that Bitcoin is a currency, correct? It literally is money and if you aren't in this for Bitcoin then...

@krtschmr
Copy link

i would like to give about 150kzols hashing power. how can i support your directly during the pre-mine stage?

@k06a
Copy link

k06a commented Oct 18, 2017

@krtschmr hashing power is not necessary for premining stage at all. "Premaining" mean exclusive access to the blockchain branch.

@ekryski
Copy link

ekryski commented Oct 20, 2017

Well, you could consider premining to be the very beginning it is released. In my mind this isn't "pre" mining. It's just a case of "early bird gets the worm". In that case it matters if you have a lot of hashing power. The faster you can mine before others the more 💰 you'll make.

@plwalters
Copy link

That's not how it works, it's not really "pre-mining" because no one else is competing for the blocks and the blocks are available on the BTC blockchain so they are basically just taking everyone else's hashing power and plucking it and just putting it in their wallets. First sign of a scam.

tan-kitty added a commit to tan-kitty/BTCGPU that referenced this pull request Oct 21, 2017
@mmortal03
Copy link

Yeah, it's more like an instamine stash than a premine.

@leto
Copy link
Contributor

leto commented Oct 22, 2017

@mmortal03 do you know of any other coins which have done an "instamine stash" ? I would be interested to compare

@mmortal03
Copy link

Dash has been accused of doing an instamine, for instance, but, actually, I think I had a brain fart earlier -- this is a premine, but it's not clear to me that they're even having to use hash power to mine it (which is what I was getting caught up on), but I don't think that really matters much in the end -- they're still essentially just giving themselves money.

@marcus-grant
Copy link

Am I incorrect in this assessment? You are asking for yourselves, 200,000BTG as rewarded cache of coin supply for developing the fork. 200,000 coins is 200,000/16.6 million BTC in circulation today. Or about 1.2% of the supply of the currency. Doesn't that seem excessive to anyone or am I misunderstanding something about how supply is changing hands between the two sides of the fork? Even if significant mining resources get committed to the fork to increase supply, for some time you would essentially own 1.2% of the currency.

@mahieddine
Copy link

Congrats ! seems like the values defended by Satoshi are gone :/

@adnjoo
Copy link

adnjoo commented Oct 24, 2017

I hope you decide to donate the Premine to charity instead of using it for yourself selfishly.

@dan-klasson
Copy link

Guys, this is an issue tracker. If you have an issue that is not programming related, there are other places to discuss that.

@k06a
Copy link

k06a commented Oct 27, 2017

@dan-klasson it is right place to discuss dev decisions.

malei pushed a commit to malei/BitcoinX that referenced this pull request Dec 6, 2017
Set PremineWindow to 16000
malei pushed a commit to malei/BitcoinX that referenced this pull request Dec 6, 2017
h4x3rotab added a commit that referenced this pull request Dec 20, 2017
h4x3rotab added a commit that referenced this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet