Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #242

Merged
merged 1,012 commits into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
1012 commits
Select commit Hold shift + click to select a range
b5e173e
changed order in docker install sh for dummy data import
saramonzon Jul 27, 2023
b1c5173
added again first install tables in docker install sh
saramonzon Jul 27, 2023
2a0daea
fixing minor bugs docker install
saramonzon Jul 27, 2023
8b4dfd6
added species in test_data.json
saramonzon Jul 27, 2023
713fbca
removed organization name from wetlab index
saramonzon Jul 27, 2023
f2377a3
docker system working with test data
saramonzon Jul 27, 2023
6e48b0a
added collection kit values to admin
saramonzon Jul 27, 2023
49bfe36
updated with upload service file folder
luissian Jul 27, 2023
a7cff42
Fixed first part of issue #207 Error adding options to option list in…
luissian Jul 27, 2023
cff67cb
Fixed second part of issue #207 Error adding options to option list i…
luissian Jul 27, 2023
42210f0
liting for migration.alterfield for uploadservicefile
luissian Jul 27, 2023
4838e0a
renamed SampleShets and SampleSheets4LibPrep folder at installation t…
luissian Jul 27, 2023
0531ee6
Fixed issue #206 BUG when displaying NovaSeq Test Run
luissian Jul 27, 2023
c083965
change COPY_SAMPLE_SHEET_TO_REMOTE to False
luissian Jul 28, 2023
d883f2e
removed COPY_SAMPLE_SHEET_TO_REMOTE to include in table configuration
luissian Jul 28, 2023
309ef37
fixed issue #200 Problem with recorded runs using folder
luissian Jul 28, 2023
cd947c9
create COPY_SAMPLE_SHEET_TO_REMOTE for wetlab config
luissian Jul 28, 2023
3a52845
Added only recorded in optional type of samples and save opt values a…
luissian Jul 28, 2023
02fc78e
implemented issue #211. Simplify the analyze_input_samples function t…
luissian Jul 28, 2023
6ee7ddc
Added missing import tags when quering SampleType
luissian Jul 28, 2023
2b5cf86
Fixed issue #199 Pool table must be a jexcel table so you can select …
luissian Jul 29, 2023
7ccd0d4
fixing error in library_id comparatation to True
luissian Jul 29, 2023
40a66b1
comment sample_fields definition in wetalb-api-views
luissian Jul 29, 2023
8e3bdd0
Update wetlab/templates/wetlab/modify_sample_project_fields.html
saramonzon Aug 1, 2023
888c63a
move samplesheet to test
saramonzon Jul 27, 2023
1fffd92
try to remove virtualenv from docker
saramonzon Jul 28, 2023
22719fc
fixed cron working in docker
saramonzon Jul 28, 2023
669ba88
change dockerfile url to buisciii's
saramonzon Jul 28, 2023
776c084
refactor record sample html, and removed reprocess code that was not …
saramonzon Jul 28, 2023
81acb50
added template tags to obtain verbose and name from field object
saramonzon Aug 1, 2023
c834119
fixed template tag fields
saramonzon Aug 1, 2023
f43b77c
naming refactoring, start rewriting record samples functionality with…
saramonzon Aug 1, 2023
eaeab6d
simple record samples working
saramonzon Aug 3, 2023
ebdbacf
remove import pdb left
saramonzon Aug 3, 2023
e15f054
linting
saramonzon Aug 3, 2023
7f4073f
black linting
saramonzon Aug 3, 2023
fa2b472
linting
saramonzon Aug 3, 2023
e9a63fc
linting pr
saramonzon Aug 3, 2023
1da32d6
implement many script migrations
luissian Aug 1, 2023
57fb62c
implementing run can be defined if exist by cron
luissian Aug 1, 2023
4288f93
implement issue #201 . Allow to create run (via pool data) even if ru…
luissian Aug 1, 2023
abb148a
fixing litin
luissian Aug 1, 2023
37ac0e3
Fixed issue #214 unable to fetch sample sheet files from existing runs
luissian Aug 1, 2023
8061005
fixed liin
luissian Aug 1, 2023
7fa09b7
fixed litin
luissian Aug 1, 2023
e8d2d65
fixed issue that when resolution was in progress in my pending servic…
luissian Aug 1, 2023
79fc070
replace error.html by pending_services.html
luissian Aug 1, 2023
6095c7a
rename file to run docker to bash docker_install.sh
luissian Aug 1, 2023
1f1bc9a
Update to Django 4.2
luissian Aug 2, 2023
f3c3e09
implemented issue #215. Show the samples that could be included in s…
luissian Aug 3, 2023
c0cf9c3
rename version of the migration files to 3.0.0
luissian Aug 4, 2023
e32415d
updated program version icons at Readme
luissian Aug 7, 2023
c6daf6e
Moved rsync command outside of upgrade_venv
svarona Aug 9, 2023
587dfbc
Updated MariaDB requirement
svarona Aug 9, 2023
d8de8c7
Updated ugettext_lazy to gettext_lazy
svarona Aug 9, 2023
6602eb5
Added code to replace database names for migration
svarona Aug 11, 2023
58ad9cb
Changed version of core
svarona Aug 11, 2023
4100066
refactored jspreadsheet_to_excel and header_to_fieldname functions
saramonzon Aug 7, 2023
88ea407
added repeat procedure when invalid sample info
saramonzon Aug 8, 2023
38a98ed
fixed search footer datatable
saramonzon Aug 8, 2023
79fb4f8
function documented
saramonzon Aug 14, 2023
aa04599
created function for extracting project fields to pass to form
saramonzon Aug 21, 2023
a05b71a
fixed errors with project_id vs name in project fields table
saramonzon Aug 21, 2023
1a8ac05
removed unused variable passed to template and fixed excluded clause …
saramonzon Aug 22, 2023
1b1c623
added record project field html for the project data forms
saramonzon Aug 22, 2023
a2e2ad4
linting, added code (not working) for project saving)
saramonzon Aug 23, 2023
1984dc7
linting, remove import pdb
saramonzon Aug 23, 2023
c2ab8e2
black linting
saramonzon Aug 23, 2023
285e698
import fixing and some refactor in wetlab api
saramonzon Aug 23, 2023
87912db
refactor record project fields
saramonzon Aug 23, 2023
6d1cd5a
some camelcase to snake case
saramonzon Aug 23, 2023
984f081
reordening wetlab api serializers
saramonzon Aug 23, 2023
f816605
linting
saramonzon Aug 23, 2023
ce99119
Added some migrations needed
svarona Aug 14, 2023
19042c9
Added verbose name to patient_core
svarona Aug 14, 2023
6cfde41
Added migration for patient core
svarona Aug 14, 2023
8d87c26
Renamed some error messages
svarona Aug 17, 2023
e5820b2
Rewritted some error messages
svarona Aug 17, 2023
5ee6661
removed check_if_sample_project_exists function
svarona Aug 23, 2023
2fcdf36
Renamed optional_fields with mandatory_fields
svarona Aug 23, 2023
8a5f836
Removed get_sample_type function
svarona Aug 23, 2023
c219118
Updated renamed ERRORs from core config
svarona Aug 23, 2023
52c35e8
removed unused check_if_sample_already_defined function
svarona Aug 23, 2023
b0f52c4
Removed unused config variables
svarona Aug 23, 2023
4ab474c
replaced numeric optional fields with mandatory string fields
svarona Aug 23, 2023
fdc48cd
sorted imports
svarona Aug 23, 2023
7ec295e
Removed get_sample_type and made it one line
svarona Aug 23, 2023
6395ab1
obtain optional fields using get_fields
svarona Aug 23, 2023
959e9b0
Changed optional_fields to missing mandatory fields
svarona Aug 23, 2023
6817cf7
Updated define type of sample html file
svarona Aug 23, 2023
1ad166a
Add test to check if table is emty before validation
svarona Aug 23, 2023
9d5e75d
Added functions and error messages for validation
svarona Aug 23, 2023
13bdc23
Fixed black linting
svarona Aug 23, 2023
35088bf
Made error_cause in check_mandatory_fields_included same as in other …
svarona Aug 24, 2023
943deb0
linting
svarona Aug 24, 2023
6611651
Fixed duplicated import
svarona Aug 24, 2023
46607eb
pep8 format
svarona Aug 24, 2023
317ca73
linting and pep8
svarona Aug 24, 2023
11d2596
make sample project serializer and obtain project fields using that i…
saramonzon Aug 23, 2023
482a8cd
incomplete pr, working up to project data save
saramonzon Aug 28, 2023
b49b980
black linting
saramonzon Aug 28, 2023
0ea2dd7
minor fix, added exclude import from linting
saramonzon Aug 28, 2023
d4f4374
Fixed Download Spreadsheet button
svarona Aug 25, 2023
49b9824
Removed date validation
svarona Aug 28, 2023
7cbf8fb
Added errors and heading for batch validation
svarona Aug 28, 2023
82f438d
added functions to load and validate batch file
svarona Aug 28, 2023
38e0752
added pandas and sorted
svarona Aug 28, 2023
7883d50
black linting
svarona Aug 28, 2023
e4e70cb
Fixed how error shows
svarona Aug 28, 2023
2540d30
Fixed pep8 lintingg
svarona Aug 28, 2023
08b7665
black
svarona Aug 28, 2023
4c856ae
pep8
svarona Aug 28, 2023
8cac9c9
Updated django version in iccon
luissian Aug 24, 2023
9989ba7
replace relecov reference when creating database
luissian Aug 27, 2023
1d30da0
fixed bug in fetchRunInformation api request
luissian Aug 28, 2023
b1cf3e1
remove functions get_sample_in_project_obj_from_id to be included in …
luissian Aug 28, 2023
a718bcf
fixed bugs and update fetch_sample_information
luissian Aug 28, 2023
b0bf0d4
liting
luissian Aug 28, 2023
4173e93
fixing bug in Laboratory data
luissian Aug 28, 2023
53b000e
fixed bug in summarize data information
luissian Aug 28, 2023
0662368
liting
luissian Aug 28, 2023
ddc49ef
fixing bugs in API when creating a new sample
luissian Aug 29, 2023
e0c2058
allow in api update lab by using coding name
luissian Aug 29, 2023
2a85b28
Added new parameter on SampleSerializer to return field_names or labe…
luissian Aug 29, 2023
2fbdad6
deleted unused function get_attributes_remote_file at common.py
luissian Aug 29, 2023
fc0c7d8
implemented issue #224. Crontab sets directly to error when runParame…
luissian Aug 29, 2023
16f5260
added dummy project validation function and fixed save_project_data
saramonzon Aug 29, 2023
9c3a690
minor modifications in record_sample display
saramonzon Aug 29, 2023
5467c95
project saving and validation behaviour
saramonzon Aug 29, 2023
d521141
added fields to sample serializer, and change to output both label an…
saramonzon Aug 29, 2023
6d40c38
prooject saving working if validation ok
saramonzon Aug 29, 2023
b482d23
added new template tag
saramonzon Aug 30, 2023
67e564e
project data when not validated working
saramonzon Aug 30, 2023
20d9901
fixes so it works well when only_recorded, and implemented pre_def fo…
saramonzon Aug 31, 2023
ddc8abe
fixes when project is None
saramonzon Aug 31, 2023
80598dd
black formatting
saramonzon Aug 31, 2023
8c36353
black linting after black upgrade
saramonzon Aug 31, 2023
22b10f9
add parameter that were missing in commit for issue #224
luissian Aug 31, 2023
4599113
Fixing bug in the implementation of issue #224
luissian Sep 3, 2023
c84cff7
rename configuration name for sending email on error
luissian Sep 3, 2023
686449d
added waiting time for run metrics fetching in crontab
saramonzon Sep 1, 2023
59f997c
black linting
saramonzon Sep 1, 2023
a5ac976
fix bug get create time from file
saramonzon Sep 4, 2023
eb1c1a7
added changes in models in custom migration
saramonzon Sep 4, 2023
8a31acd
created new template tag to clean strings from weird characters
saramonzon Sep 4, 2023
7f23db0
fixed string cleaning stuff and hidden if
saramonzon Sep 4, 2023
2752c4b
remove missing import pdb
saramonzon Sep 4, 2023
ad2fccf
black linting
saramonzon Sep 4, 2023
d39c193
fixed drylab api errors
saramonzon Sep 5, 2023
8d4573f
format imports in drylab api
saramonzon Sep 5, 2023
5a55e90
minor fixes and linting in display services
saramonzon Sep 5, 2023
7708b23
black linting
saramonzon Sep 5, 2023
42476e1
implemented migration for sample type
luissian Sep 5, 2023
1f87426
Update code for displaying mandatory sample type
luissian Sep 5, 2023
50719cc
liting
luissian Sep 5, 2023
3d2613d
liting
luissian Sep 5, 2023
3b9f845
liting
luissian Sep 5, 2023
ac0945b
Include sample project name in display sample project information
luissian Sep 5, 2023
596c2bd
Fixed bug when updating sample project fields
luissian Sep 5, 2023
7890cf4
Implemented migration for optional fields at sample Project fields
luissian Sep 5, 2023
8356eab
reformating code when creating new sample project fields
luissian Sep 5, 2023
a53dec0
litin and remove debuging code
luissian Sep 5, 2023
6142d3f
litin
luissian Sep 5, 2023
f35a32a
updated README to include the script migrate_optional_values
luissian Sep 5, 2023
0d1b8d7
Update README.md
saramonzon Sep 6, 2023
333ba82
move project validation to batch instead of validate and added specie…
svarona Aug 30, 2023
0865653
removed len 0 to not
svarona Aug 30, 2023
b804095
removed project columns from invalid_col_name
svarona Aug 30, 2023
02a003c
move empty df validation
svarona Aug 30, 2023
5212190
indent
svarona Aug 30, 2023
5edf8c7
commit before rebase
svarona Sep 12, 2023
3c16738
Fixed project test
svarona Sep 12, 2023
f2d736b
Error when project field empty
svarona Sep 12, 2023
4501a18
Test if project in the DB when is not none
svarona Sep 12, 2023
5cffa52
no need of predef samples
svarona Sep 12, 2023
df7efb4
no need of predef samples
svarona Sep 12, 2023
a3e88c5
no need of predef samples
svarona Sep 12, 2023
5be1c35
Added empty project error
svarona Sep 12, 2023
3a8966a
test if there are projects to add info
svarona Sep 12, 2023
5fbbc5b
Created validation function
svarona Sep 18, 2023
433e522
Added project validation errors
svarona Sep 18, 2023
30e74df
Fixed species variable error
svarona Sep 18, 2023
216a905
Added function to obtain real only_recorded value, which is empty
svarona Sep 18, 2023
c507e52
Removed no validated samples from json so they are not added
svarona Sep 18, 2023
0b63c37
Added function to record project in batch data
svarona Sep 18, 2023
8e7e1e9
added import
svarona Sep 18, 2023
eb511b6
Fixed black
svarona Sep 18, 2023
94ae1c7
fixed black
svarona Sep 18, 2023
1636a7b
added exception for all invalid fields
svarona Sep 18, 2023
8a7bbe4
Fixed pep8
svarona Sep 18, 2023
5d6db92
fixed not working test
svarona Sep 18, 2023
135080f
Fixed bug
svarona Sep 18, 2023
fb05884
Fixed only recorded and read only values
svarona Sep 19, 2023
b779b03
added only recorded to serializer
svarona Sep 19, 2023
8a93a92
Removed only recorded overwrite dont needed
svarona Sep 19, 2023
960dcd0
Allowe empty values in project data
svarona Sep 21, 2023
f0d6ffb
Allowed forone project to validate and not the other
svarona Sep 21, 2023
de62a59
Added missing columns and refactor some code
svarona Sep 21, 2023
a186826
Change validation format
svarona Sep 21, 2023
9a4ce6e
added missing header error
svarona Sep 21, 2023
004d564
Created validation for both samples and project in one
svarona Sep 21, 2023
05d969a
Fixed project name is None string
svarona Sep 21, 2023
1813b29
Fixed black
svarona Sep 21, 2023
9edf170
Removed print
svarona Sep 21, 2023
9c9a4cd
Renamed OK button to Scan Barcode
svarona Sep 21, 2023
0e7bc29
Made examples unselectables
svarona Sep 21, 2023
222439d
made table overflow
svarona Sep 22, 2023
1d6753d
Fixed variable in api
svarona Sep 22, 2023
425931d
Fixed serializer
svarona Sep 26, 2023
566b50a
Fixed black
svarona Sep 26, 2023
c065030
Added batch samples template
svarona Sep 26, 2023
2258b5b
Added code to download samples template file
svarona Sep 26, 2023
39b6881
Reformatted load batch
svarona Sep 26, 2023
9b043e7
fixed pep8
svarona Sep 26, 2023
cbb5658
removed some teting code
svarona Sep 26, 2023
ca00705
Removes spaces
svarona Sep 26, 2023
8d071b4
Addded authentication for put function
svarona Sep 27, 2023
bc75ab9
fixed issue #237. String field filled with number, gives error
luissian Oct 2, 2023
5fc00f9
fixing bugs in molecule handling
luissian Oct 3, 2023
e983241
working on handling molecules
luissian Oct 4, 2023
e2e12ef
Updated pending molecules
luissian Oct 4, 2023
fa90a9b
first liting
luissian Oct 4, 2023
8d1d2af
changes due to liting
luissian Oct 4, 2023
6344df6
fixed bug when displaying a sample that is a number
luissian Oct 4, 2023
5a01398
return to handling molecules instead of home
luissian Oct 4, 2023
7c3a418
Fixed bug when no excel is used in batch
luissian Oct 4, 2023
46ef96d
fixing litin
luissian Oct 4, 2023
e3124af
fixing litin
luissian Oct 4, 2023
f22d2ad
Fixed issue #239 Bug in statistics by service requested dashboard
luissian Oct 5, 2023
8d4eafb
Fixed bug when selecting molecule use
luissian Oct 7, 2023
f59853b
working on batch file
luissian Oct 8, 2023
f636a98
fixed bugs when uploading batch file
luissian Oct 9, 2023
1a0c652
fixed lintin
luissian Oct 9, 2023
c88166b
Fixed issue #241
luissian Oct 9, 2023
af17fa8
fixed litin
luissian Oct 9, 2023
0b4d161
Updated with changes agreed on the slack meeting
luissian Oct 10, 2023
5b91f9b
Merge branch 'main' into develop
saramonzon Oct 17, 2023
c1c99dc
fix conflict readme main
saramonzon Oct 17, 2023
9ac8e1d
minor modification install script
saramonzon Oct 17, 2023
8a8f96c
minor modification install script
saramonzon Oct 17, 2023
fad2c45
revert changes
saramonzon Oct 17, 2023
e506248
Removed availableservice from initial tables
svarona Oct 18, 2023
6f6afe0
Fixed validation error
svarona Oct 18, 2023
f710a69
Changed error message
svarona Oct 19, 2023
78bbab1
Fixed samples projec text when empty
svarona Oct 19, 2023
13f1ceb
increased avalable services length
svarona Oct 19, 2023
e4a0761
Added availableservice max_length to migrations
svarona Oct 19, 2023
2a799f2
Added new availableservice to initial table
svarona Oct 19, 2023
244a6b5
fixed some typos
svarona Oct 19, 2023
3d903fe
Set all service_id to null
svarona Oct 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
36 changes: 36 additions & 0 deletions .github/workflows/python_lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: python_lint

on:
push:
paths:
- '**.py'
pull_request:
paths:
- '**.py'

jobs:
flake8_py3:
runs-on: ubuntu-latest
steps:
- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.9.x
architecture: x64
- name: Checkout PyTorch
uses: actions/checkout@master
- name: Install flake8
run: pip install flake8
- name: Run flake8
run: flake8 --ignore E501,W503,E203,W605

black_lint:
runs-on: ubuntu-latest
steps:
- name: Setup
uses: actions/checkout@v2
- name: Install black in jupyter
run: pip install black[jupyter]
- name: Check code lints with Black
uses: psf/black@stable

7 changes: 5 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,21 @@
*.xml
*.bin
*.gz
*.csv
*_BAK
migrations/
tmp/
logs/
static/
/static/
install_settings.txt
wetlab/logging_config.ini
#--- updates introduced for iSkyLIMS in submodules packaging ---
virtualenv/
iSkyLIMS/
*iskylims/
documents/
manage.py
logs/
logs


# Byte-compiled / optimized / DLL files
Expand Down
60 changes: 17 additions & 43 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,56 +1,30 @@
FROM ubuntu:20.04
# ENV PYTHONUNBUFFERED 1
FROM ubuntu:22.04
ENV TZ=Europe/Madrid
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone

# Updates
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get upgrade -y

# Essential software
RUN apt-get install -y \
lightdm git apt-utils libcairo2 libcairo2-dev wget gnuplot python3-pip \
libmysqlclient-dev apache2 apache2-dev vim

RUN mkdir /opt/interop
WORKDIR /opt/interop

RUN wget https://github.com/Illumina/interop/releases/download/v1.1.15/InterOp-1.1.15-Linux-GNU.tar.gz
RUN tar -xvf InterOp-1.1.15-Linux-GNU.tar.gz
RUN ln -s InterOp-1.1.15-Linux-GNU interop
RUN rm InterOp-1.1.15-Linux-GNU.tar.gz


RUN mkdir /opt/iSkyLIMS
WORKDIR /opt/iSkyLIMS

RUN git clone https://github.com/BU-ISCIII/iSkyLIMS.git .

# RUN git submodule init
git wget lsb-core lsb-release \
libmysqlclient-dev \
python3-pip libpq-dev \
python3-wheel apache2-dev \
gnuplot

RUN git clone https://github.com/bu-isciii/iskylims.git /srv/iskylims
WORKDIR /srv/iskylims
RUN git checkout develop
# RUN git submodule init
# RUN git submodule update --checkout
RUN cd iSkyLIMS_wetlab git



RUN mkdir -p /opt/iSkyLIMS/documents/wetlab/tmp
RUN mkdir -p /opt/iSkyLIMS/documents/drylab
RUN mkdir -p /opt/iSkyLIMS/logs



# Starting iSkyLIMS
RUN python3 -m pip install -r conf/pythonPackagesRequired.txt
RUN django-admin startproject iSkyLIMS .
RUN /bin/bash -c 'grep ^SECRET iSkyLIMS/settings.py > ~/.secret'
RUN pip install -r conf/requirements.txt

RUN bash install.sh --install app --dev --conf conf/docker_install_settings.txt --docker

# Copying config files and script
RUN cp conf/docker_settings.py /opt/iSkyLIMS/iSkyLIMS/settings.py
RUN cp conf/urls.py /opt/iSkyLIMS/iSkyLIMS/
WORKDIR /opt/iskylims

RUN sed -i "/^SECRET/c\\$(cat ~/.secret)" iSkyLIMS/settings.py
ENV PATH="usr/bin:$PATH"
# Expose and run
EXPOSE 8000
CMD python3 manage.py runserver 0:8000
# Expose
EXPOSE 8001
# Start the application
CMD ["python3", "/opt/iskylims/manage.py", "runserver", "0:8001"]
Loading
Loading