-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.77.0 -- Fix stim events TSV issue with conditions names with spaces - we should be able to handle that. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Update DataTree shared lib submodule * DataTree, 1.12.0 -- Change AcqDataClass GetSrcPos and GetDetPos methods to ignore '2D' and instead automatically try to retrieve 3D optodes if available otherwise it retrieves 2D. This fixes the problem of retrieving non existent or artificially generated 2D optodes that do not agree with the 'LengthUnit' which is a problem when doing image reconstruction and using a non-zero SD separation to exclude channels (possibbly end up exluding ALL chaqnnels if units apply to the wrong optodes). -- Update NirsClass so SDgui matches GrommetRot being changed back to cell array type instead of numeric array.
Utils, v1.5.0 -- Fix stim events TSV issue with conditions names with spaces - we should be able to handle that. Change rule to handle spaces and how error reporting is done in readTsv. DataTree, v1.12.1 -- Don't load events TSV files twice - once in SnirfClass and once in AcqDataClass its superclass.
1.77.0 -- Fix stim events TSV issue with conditions names with spaces - we should be able to handle that. |
jayd1860
added a commit
that referenced
this pull request
May 12, 2023
Date: 5/11/2023 3:06:37 PM v1.79.3 -- Add more standalone startup function to setpaths.m to be able to independent of any startup code search paths except current folder -- Chnage default value of config param Load Stim From TSV File from no to yes. * DataTree, v1.14.2 -- Fix events TSV file naming bug. Add TSV file name method TreeNode.GetStimTsvFilename() to use for all events TSV file naming. -- Fixes to setpaths for running DataTree standalone * Utils, v1.6.0 -- Fix some bugs in events TSV stim loading error handling. Add config param "Replace TSV File Tabs with Spaces" to handle events TSV errors when file is a mix of spaces and tabs. -- Add method ConfigFileClass.GetValueOptions for getting all available value options for a param. Date: 5/10/2023 10:52:19 AM v1.79.1 -- Fix Homer3 displaying probe in 3D rather than 2D. (#177) * DataTree, v1.14.0 -- Fix Homer3 displaying probe in 3D rather than 2D. Back out changes that default to 3D in ProbeClass and NirsClass GetSrcPos and GetDetPos for ALL cases. The way it's supposed to work is probe is supposed to use 2D coordinates ONLY when being displayed in Homer3. Rest of the time default to 3D if it exists. Reason for original change is misunderstanding of what the purpose of 2D coord was which is ONLY for display * Utils, v1.5.1 -- Add ability to simulate full dataset (generateSimData.m, simulateDataTimeSeries.m) to be able to eventually do workflow unit and system tests Date: 5/3/2023 12:38:30 PM v1.78.1 -- Fix error when displaying data, remove unnecessary call to get file descriptor: obj.fid = HDF5_GetFileDescriptor(fileobj); (#174) Date: 5/3/2023 10:52:24 AM -- Forgot to include HDF5_GetFileDescriptor.m in v1.78.0 commit. (#173) Date: 5/3/2023 10:13:49 AM v1.78.0 -- Improve saving performance of SNIRF files by using low level HDF5 library. (#172) * DataTree, v1.13.0 -- Comprehensive solution to improving the save performance of SNIRF files by using low-level HDF5 calls and limiting the number of HDF5 open and create calls that are made for file, group and dataset. Date: 4/14/2023 1:59:38 AM 1.77.0 -- Fix stim events TSV issue with conditions names with spaces - we should be able to handle that. (#170) Utils, v1.5.0 -- Fix stim events TSV issue with conditions names with spaces - we should be able to handle that. Change rule to handle spaces and how error reporting is done in readTsv. DataTree, v1.12.1 -- Don't load events TSV files twice - once in SnirfClass and once in AcqDataClass its superclass. Date: 4/11/2023 2:49:33 PM -- Sync setpaths in DataTree with DataTree library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.77.0 -- Fix stim events TSV issue with conditions names with spaces - we should be able to handle that.